You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/14 03:42:45 UTC
[GitHub] [hudi] XuQianJin-Stars opened a new pull request, #5859: [MINOR] fix file not exists for getFileSize
XuQianJin-Stars opened a new pull request, #5859:
URL: https://github.com/apache/hudi/pull/5859
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5859: [MINOR] fix file not exists for getFileSize
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5859:
URL: https://github.com/apache/hudi/pull/5859#issuecomment-1154684666
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "37b88fa48a7a70ddb3f190ee1d64b10434be8772",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37b88fa48a7a70ddb3f190ee1d64b10434be8772",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 37b88fa48a7a70ddb3f190ee1d64b10434be8772 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars closed pull request #5859: [MINOR] fix file not exists for getFileSize
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars closed pull request #5859: [MINOR] fix file not exists for getFileSize
URL: https://github.com/apache/hudi/pull/5859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5859: [MINOR] fix file not exists for getFileSize
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5859:
URL: https://github.com/apache/hudi/pull/5859#discussion_r896349614
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -189,7 +189,11 @@ public static String getCommitTime(String fullFileName) {
}
public static long getFileSize(FileSystem fs, Path path) throws IOException {
- return fs.getFileStatus(path).getLen();
+ if (fs.exists(path)) {
+ return fs.getFileStatus(path).getLen();
+ } else {
+ return 0L;
+ }
Review Comment:
What is the context here ? Can we ensure the file must exist when calling the `getFileSize`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5859: [MINOR] fix file not exists for getFileSize
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5859:
URL: https://github.com/apache/hudi/pull/5859#issuecomment-1154686588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "37b88fa48a7a70ddb3f190ee1d64b10434be8772",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9279",
"triggerID" : "37b88fa48a7a70ddb3f190ee1d64b10434be8772",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 37b88fa48a7a70ddb3f190ee1d64b10434be8772 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9279)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5859: [MINOR] fix file not exists for getFileSize
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5859:
URL: https://github.com/apache/hudi/pull/5859#issuecomment-1154752551
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "37b88fa48a7a70ddb3f190ee1d64b10434be8772",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9279",
"triggerID" : "37b88fa48a7a70ddb3f190ee1d64b10434be8772",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 37b88fa48a7a70ddb3f190ee1d64b10434be8772 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9279)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org