You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/22 09:34:35 UTC
[GitHub] [flink] curcur opened a new pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
curcur opened a new pull request #14460:
URL: https://github.com/apache/flink/pull/14460
…does not apply to task failure
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
}, {
"hash" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447",
"triggerID" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"triggerType" : "PUSH"
}, {
"hash" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11537",
"triggerID" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11537)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749447681
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 25757130265c21142058fb95370ca686a4d915f9 (Fri May 28 06:59:46 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749447681
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cc8023ddd40346c2c7aad92008ac7140f95a1459 (Tue Dec 22 09:36:35 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
}, {
"hash" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447",
"triggerID" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"triggerType" : "PUSH"
}, {
"hash" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11537",
"triggerID" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"triggerType" : "PUSH"
}, {
"hash" : "25757130265c21142058fb95370ca686a4d915f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11583",
"triggerID" : "25757130265c21142058fb95370ca686a4d915f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11537)
* 25757130265c21142058fb95370ca686a4d915f9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11583)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc8023ddd40346c2c7aad92008ac7140f95a1459 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
}, {
"hash" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447",
"triggerID" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"triggerType" : "PUSH"
}, {
"hash" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11537",
"triggerID" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f59e7821f3e7649b5449307a7a4817a4d0036f5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447)
* 9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11537)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
}, {
"hash" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447",
"triggerID" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"triggerType" : "PUSH"
}, {
"hash" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f59e7821f3e7649b5449307a7a4817a4d0036f5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447)
* 9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #14460:
URL: https://github.com/apache/flink/pull/14460#discussion_r549560865
##########
File path: docs/_includes/generated/all_taskmanager_section.html
##########
@@ -18,7 +18,7 @@
<td><h5>task.cancellation.timeout</h5></td>
<td style="word-wrap: break-word;">180000</td>
<td>Long</td>
- <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog.</td>
+ <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog. Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure.</td>
Review comment:
1. That's true in the sense that `cleanUpInvoke` is called both in the case of a task failure and a clean shutdown. But I thought `task-cancelation-timeout` naturally can not be considered as applied to a clean shutdown? The main confusion in general (and in the ticket FLINK-18983) is that people thought "task-cancelation-timeout" can be applied for "failed tasks" as well.
2. Task cancelation does not always happen "manually", it can happen when a task fails and caused the rest of the tasks canceled by JM. So I would say "task cancelation" instead of saying "manually cancel the job"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa3a798b659292251207db7dc1c762af9e2553a4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-752028967
rebased and updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #14460:
URL: https://github.com/apache/flink/pull/14460#discussion_r549560968
##########
File path: docs/_includes/generated/all_taskmanager_section.html
##########
@@ -18,7 +18,7 @@
<td><h5>task.cancellation.timeout</h5></td>
<td style="word-wrap: break-word;">180000</td>
<td>Long</td>
- <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog.</td>
+ <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog. Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure.</td>
Review comment:
> > Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure
>
> ->
>
> > Notice that a task cancellation is different from both a task failure and a clean shutdown. So task cancellation timeout applies only if you manually cancel the job and does not apply to task closing/clean-up caused by a task failure or clean shutdown.
>
> ? Because as I understand, this notice applies as well for the clean shut down?
1. That's true in the sense that `cleanUpInvoke` is called both in the case of a task failure and a clean shutdown. But I thought `task-cancelation-timeout` naturally can not be considered as applied to a clean shutdown? Would that cause more confusion if we say that? The main confusion in general (and in the ticket FLINK-18983) is that people thought "task-cancelation-timeout" can be applied for "failed tasks" as well.
2. Task cancelation does not always happen "manually", it can happen when a task fails and caused the rest of the tasks canceled by JM. So I would suggest "task cancelation" instead of saying "manually cancel the job"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #14460:
URL: https://github.com/apache/flink/pull/14460#discussion_r549316156
##########
File path: docs/_includes/generated/all_taskmanager_section.html
##########
@@ -18,7 +18,7 @@
<td><h5>task.cancellation.timeout</h5></td>
<td style="word-wrap: break-word;">180000</td>
<td>Long</td>
- <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog.</td>
+ <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog. Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure.</td>
Review comment:
> Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure
->
> Notice that a task cancellation is different from both a task failure and a clean shutdown. So task cancellation timeout applies only if you manually cancel the job and does not apply to task closing/clean-up caused by a task failure or clean shutdown.
? Because as I understand, this notice applies as well for the clean shut down?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #14460:
URL: https://github.com/apache/flink/pull/14460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc8023ddd40346c2c7aad92008ac7140f95a1459 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
}, {
"hash" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447",
"triggerID" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"triggerType" : "PUSH"
}, {
"hash" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11537",
"triggerID" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"triggerType" : "PUSH"
}, {
"hash" : "25757130265c21142058fb95370ca686a4d915f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "25757130265c21142058fb95370ca686a4d915f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11537)
* 25757130265c21142058fb95370ca686a4d915f9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #14460:
URL: https://github.com/apache/flink/pull/14460#discussion_r549560968
##########
File path: docs/_includes/generated/all_taskmanager_section.html
##########
@@ -18,7 +18,7 @@
<td><h5>task.cancellation.timeout</h5></td>
<td style="word-wrap: break-word;">180000</td>
<td>Long</td>
- <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog.</td>
+ <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog. Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure.</td>
Review comment:
> > Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure
>
> ->
>
> > Notice that a task cancellation is different from both a task failure and a clean shutdown. So task cancellation timeout applies only if you manually cancel the job and does not apply to task closing/clean-up caused by a task failure or clean shutdown.
>
> ? Because as I understand, this notice applies as well for the clean shut down?
1. That's true in the sense that `cleanUpInvoke` is called both in the case of a task failure and a clean shutdown. But I thought `task-cancelation-timeout` naturally can not be considered as applied to a clean shutdown? Would that cause more confusion if we say that? The main confusion in general (and in the ticket FLINK-18983) is that people thought "task-cancelation-timeout" can be applied for "failed tasks" as well.
2. Task cancelation does not always happen "manually", it can happen when a task fails and caused the rest of the tasks canceled by JM. So I would say "task cancelation" instead of saying "manually cancel the job"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-752895866
I rebuild the docs, let's see whether it fixes the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc8023ddd40346c2c7aad92008ac7140f95a1459 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174)
* aa3a798b659292251207db7dc1c762af9e2553a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-752171554
The documentation build is failing I think after the update?
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=11447&view=logs&j=fc5181b0-e452-5c8f-68de-1097947f6483&t=62110053-334f-5295-a0ab-80dd7e2babbf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #14460:
URL: https://github.com/apache/flink/pull/14460#discussion_r549560968
##########
File path: docs/_includes/generated/all_taskmanager_section.html
##########
@@ -18,7 +18,7 @@
<td><h5>task.cancellation.timeout</h5></td>
<td style="word-wrap: break-word;">180000</td>
<td>Long</td>
- <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog.</td>
+ <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog. Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure.</td>
Review comment:
> > Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure
>
> ->
>
> > Notice that a task cancellation is different from both a task failure and a clean shutdown. So task cancellation timeout applies only if you manually cancel the job and does not apply to task closing/clean-up caused by a task failure or clean shutdown.
>
> ? Because as I understand, this notice applies as well for the clean shut down?
1. That's true in the sense that `cleanUpInvoke` is called both in the case of a task failure and a clean shutdown. But I thought `task-cancelation-timeout` naturally can not be considered as applied to a clean shutdown? The main confusion in general (and in the ticket FLINK-18983) is that people thought "task-cancelation-timeout" can be applied for "failed tasks" as well.
2. Task cancelation does not always happen "manually", it can happen when a task fails and caused the rest of the tasks canceled by JM. So I would say "task cancelation" instead of saying "manually cancel the job"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
}, {
"hash" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa3a798b659292251207db7dc1c762af9e2553a4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289)
* 5f59e7821f3e7649b5449307a7a4817a4d0036f5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc8023ddd40346c2c7aad92008ac7140f95a1459 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174)
* aa3a798b659292251207db7dc1c762af9e2553a4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc8023ddd40346c2c7aad92008ac7140f95a1459 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #14460:
URL: https://github.com/apache/flink/pull/14460#discussion_r549609731
##########
File path: docs/_includes/generated/all_taskmanager_section.html
##########
@@ -18,7 +18,7 @@
<td><h5>task.cancellation.timeout</h5></td>
<td style="word-wrap: break-word;">180000</td>
<td>Long</td>
- <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog.</td>
+ <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog. Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure.</td>
Review comment:
1. I would suggest to add clean shutdown mention, because up till the moment I started reading your PR, I was sure that the FLINK-18983 is all about clean shutdown 😓 So the mis conception can go in both directions .
2. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
}, {
"hash" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447",
"triggerID" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f59e7821f3e7649b5449307a7a4817a4d0036f5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
}, {
"hash" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447",
"triggerID" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"triggerType" : "PUSH"
}, {
"hash" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11537",
"triggerID" : "9f7dd68a258dd3ccc7655a5e4c8e819822fc1d8c",
"triggerType" : "PUSH"
}, {
"hash" : "25757130265c21142058fb95370ca686a4d915f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11583",
"triggerID" : "25757130265c21142058fb95370ca686a4d915f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 25757130265c21142058fb95370ca686a4d915f9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11583)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14460:
URL: https://github.com/apache/flink/pull/14460#issuecomment-749464826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11174",
"triggerID" : "cc8023ddd40346c2c7aad92008ac7140f95a1459",
"triggerType" : "PUSH"
}, {
"hash" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289",
"triggerID" : "aa3a798b659292251207db7dc1c762af9e2553a4",
"triggerType" : "PUSH"
}, {
"hash" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447",
"triggerID" : "5f59e7821f3e7649b5449307a7a4817a4d0036f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa3a798b659292251207db7dc1c762af9e2553a4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11289)
* 5f59e7821f3e7649b5449307a7a4817a4d0036f5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11447)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #14460: [docs/javadoc][hotfix] Explicitly Document task cancellation timeout …
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #14460:
URL: https://github.com/apache/flink/pull/14460#discussion_r549560968
##########
File path: docs/_includes/generated/all_taskmanager_section.html
##########
@@ -18,7 +18,7 @@
<td><h5>task.cancellation.timeout</h5></td>
<td style="word-wrap: break-word;">180000</td>
<td>Long</td>
- <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog.</td>
+ <td>Timeout in milliseconds after which a task cancellation times out and leads to a fatal TaskManager error. A value of 0 deactivates the watch dog. Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure.</td>
Review comment:
> > Notice that a task cancellation is different from a task failure. So task cancellation timeout does not apply to task closing/clean-up caused by a task failure
>
> ->
>
> > Notice that a task cancellation is different from both a task failure and a clean shutdown. So task cancellation timeout applies only if you manually cancel the job and does not apply to task closing/clean-up caused by a task failure or clean shutdown.
>
> ? Because as I understand, this notice applies as well for the clean shut down?
1. That's true in the sense that cleanUpInvoke is called both in the case of a task failure and a clean shutdown. But I thought task-cancelation-timeout naturally can not be considered as applied to a clean shutdown? The main confusion in general (and in the ticket FLINK-18983) is that people thought "task-cancelation-timeout" can be applied for "failed tasks" as well.
2. Task cancelation does not always happen "manually", it can happen when a task fails and caused the rest of the tasks canceled by JM. So I would say "task cancelation" instead of saying "manually cancel the job"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org