You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/26 15:56:00 UTC
[GitHub] [incubator-seatunnel] laglangyue opened a new pull request, #2410: [Feature][Connector-V2][JDBC] Support DB2 Source & Sink
laglangyue opened a new pull request, #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
support connnector-jdbc-v2 DB2
https://github.com/apache/incubator-seatunnel/issues/2367
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on a diff in pull request #2410: [Connector-V2][JDBC-connector] support database: DB2
Posted by GitBox <gi...@apache.org>.
ic4y commented on code in PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#discussion_r945395895
##########
pom.xml:
##########
@@ -352,6 +353,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.ibm.db2</groupId>
+ <artifactId>jcc</artifactId>
+ <version>${db2.version}</version>
+ </dependency>
Review Comment:
This scope need to be test, Like DM. And no need to add a license.
Is it right? @ashulin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2410: [Feature][Connector-V2][JDBC] Support DB2 Source & Sink
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#discussion_r1003495660
##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-jdbc-spark-e2e/pom.xml:
##########
@@ -96,6 +96,13 @@
<groupId>com.microsoft.sqlserver</groupId>
<artifactId>mssql-jdbc</artifactId>
</dependency>
+
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>db2</artifactId>
+ <version>1.17.3</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
remove？
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcDb2IT.java:
##########
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.jdbc;
+
+import org.apache.seatunnel.connectors.seatunnel.jdbc.util.JdbcCompareUtil;
+import org.apache.seatunnel.e2e.common.TestResource;
+import org.apache.seatunnel.e2e.common.TestSuiteBase;
+import org.apache.seatunnel.e2e.common.container.TestContainer;
+
+import com.google.common.collect.Lists;
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigFactory;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestTemplate;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.Container;
+import org.testcontainers.containers.Db2Container;
+import org.testcontainers.containers.output.Slf4jLogConsumer;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URL;
+import java.sql.Connection;
+import java.sql.Driver;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.Properties;
+
+public class JdbcDb2IT extends TestSuiteBase implements TestResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(JdbcDb2IT.class);
+ /**
+ * <a href="https://hub.docker.com/r/ibmcom/db2">db2 in dockerhub</a>
+ */
+ private static final String IMAGE = "ibmcom/db2";
+ private static final String HOST = "e2e_db2";
+ private static final int PORT = 50000;
+ private static final int LOCAL_PORT = 50000;
+ private static final String USER = "db2inst1";
+ private static final String PASSWORD = "123456";
+
+ private static final String DATABASE = "E2E";
+ private static final String SOURCE_TABLE = "E2E_TABLE_SOURCE";
+ private static final String SINK_TABLE = "E2E_TABLE_SINK";
+ private String jdbcUrl;
+ private Db2Container db2;
+ private Connection jdbcConnection;
+
+ @BeforeAll
+ @Override
+ public void startUp() throws Exception {
+ db2 = new Db2Container(IMAGE)
+ .withExposedPorts(PORT)
+ .withNetwork(NETWORK)
+ .withNetworkAliases(HOST)
+ .withDatabaseName(DATABASE)
+ .withUsername(USER)
+ .withPassword(PASSWORD)
+ .withLogConsumer(new Slf4jLogConsumer(LOG))
Review Comment:
```suggestion
.withLogConsumer(new Slf4jLogConsumer(DockerLoggerFactory.getLogger(IMAGE)))
```
##########
seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/jdbc_db2_source_and_sink.conf:
##########
@@ -0,0 +1,90 @@
+#
Review Comment:
Do not commit examples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2410: [Connector-V2][JDBC-connector] support database: DB2
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#discussion_r945433946
##########
pom.xml:
##########
@@ -352,6 +353,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.ibm.db2</groupId>
+ <artifactId>jcc</artifactId>
+ <version>${db2.version}</version>
+ </dependency>
Review Comment:
@CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2410: [Connector-V2][JDBC-connector] support database: DB2
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#discussion_r945382547
##########
pom.xml:
##########
@@ -352,6 +353,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.ibm.db2</groupId>
+ <artifactId>jcc</artifactId>
+ <version>${db2.version}</version>
+ </dependency>
Review Comment:
Some Notices & License need to be added. https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/release-docs/NOTICE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on a diff in pull request #2410: [Connector-V2][JDBC-connector] support database: DB2
Posted by GitBox <gi...@apache.org>.
ic4y commented on code in PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#discussion_r964582129
##########
pom.xml:
##########
@@ -303,6 +304,12 @@
<version>${postgresql.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.ibm.db2.jcc</groupId>
+ <artifactId>db2jcc</artifactId>
+ <version>db2jcc4</version>
+ </dependency>
+
Review Comment:
Put it under `seatunnel-connectors-v2/connector-jdbc/pom.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 closed pull request #2410: [Feature][Connector-V2][JDBC] Support DB2 Source & Sink
Posted by GitBox <gi...@apache.org>.
EricJoy2048 closed pull request #2410: [Feature][Connector-V2][JDBC] Support DB2 Source & Sink
URL: https://github.com/apache/incubator-seatunnel/pull/2410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on a diff in pull request #2410: [Feature][Connector-V2][JDBC] Support DB2 Source & Sink
Posted by GitBox <gi...@apache.org>.
laglangyue commented on code in PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#discussion_r1005812130
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcDb2IT.java:
##########
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.jdbc;
+
+import org.apache.seatunnel.connectors.seatunnel.jdbc.util.JdbcCompareUtil;
+import org.apache.seatunnel.e2e.common.TestResource;
+import org.apache.seatunnel.e2e.common.TestSuiteBase;
+import org.apache.seatunnel.e2e.common.container.TestContainer;
+
+import com.google.common.collect.Lists;
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigFactory;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestTemplate;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.Container;
+import org.testcontainers.containers.Db2Container;
+import org.testcontainers.containers.output.Slf4jLogConsumer;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URL;
+import java.sql.Connection;
+import java.sql.Driver;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.Properties;
+
+public class JdbcDb2IT extends TestSuiteBase implements TestResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(JdbcDb2IT.class);
+ /**
+ * <a href="https://hub.docker.com/r/ibmcom/db2">db2 in dockerhub</a>
+ */
+ private static final String IMAGE = "ibmcom/db2";
+ private static final String HOST = "e2e_db2";
+ private static final int PORT = 50000;
+ private static final int LOCAL_PORT = 50000;
+ private static final String USER = "db2inst1";
+ private static final String PASSWORD = "123456";
+
+ private static final String DATABASE = "E2E";
+ private static final String SOURCE_TABLE = "E2E_TABLE_SOURCE";
+ private static final String SINK_TABLE = "E2E_TABLE_SINK";
+ private String jdbcUrl;
+ private Db2Container db2;
+ private Connection jdbcConnection;
+
+ @BeforeAll
+ @Override
+ public void startUp() throws Exception {
+ db2 = new Db2Container(IMAGE)
+ .withExposedPorts(PORT)
+ .withNetwork(NETWORK)
+ .withNetworkAliases(HOST)
+ .withDatabaseName(DATABASE)
+ .withUsername(USER)
+ .withPassword(PASSWORD)
+ .withLogConsumer(new Slf4jLogConsumer(LOG))
Review Comment:
done. BTW can you tell me why.
##########
seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/jdbc_db2_source_and_sink.conf:
##########
@@ -0,0 +1,90 @@
+#
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #2410: [Feature][Connector-V2][JDBC] Support DB2 Source & Sink
Posted by GitBox <gi...@apache.org>.
EricJoy2048 merged PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on a diff in pull request #2410: [Connector-V2][JDBC-connector] support database: DB2
Posted by GitBox <gi...@apache.org>.
laglangyue commented on code in PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#discussion_r948622775
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/db2/DB2DialectFactory.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.db2;
+
+
+import org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.JdbcDialect;
+import org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.JdbcDialectFactory;
+
+import com.google.auto.service.AutoService;
+
+/**
+ * Factory for {@link DB2Dialect}.
+ */
+
+@AutoService(JdbcDialectFactory.class)
+public class DB2DialectFactory implements JdbcDialectFactory {
+
+ @Override
+ public boolean acceptsURL(String url) {
+ return url.startsWith("jdbc:mysql:");
Review Comment:
yes，I will compilt it with the e2e test this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2410: [Connector-V2][JDBC-connector] support database: DB2
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#issuecomment-1223490498
> this PR may be delay，I am finishing the DM. I spent some time studying the testcontainer，more of environment and DM images.
take your time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2410: [Connector-V2][JDBC-connector] support database: DB2
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#issuecomment-1214611387
> @laglangyue Wait for the JDBC e2e test (#2321) to merge. You need to add test for DB2 in jdbc e2e test
yes, the test is very nice. I test in local（laglangyue:jdbc_dm_test），but not quickly .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2410: [Feature][Connector-V2][JDBC] Support DB2 Source & Sink
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#issuecomment-1287248599
@ic4y @hailin0 @CalvinKirs I has finiehed the e2e。
There are many problems with the DB2 container. I spent a lot of time studying the disconnection of the DB2 container and SQL compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on a diff in pull request #2410: [Feature][Connector-V2][JDBC] Support DB2 Source & Sink
Posted by GitBox <gi...@apache.org>.
laglangyue commented on code in PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#discussion_r1005812504
##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-jdbc-spark-e2e/pom.xml:
##########
@@ -96,6 +96,13 @@
<groupId>com.microsoft.sqlserver</groupId>
<artifactId>mssql-jdbc</artifactId>
</dependency>
+
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>db2</artifactId>
+ <version>1.17.3</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2410: [Feature][Connector-V2][JDBC] Support DB2 Source & Sink
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#issuecomment-1282628903
DDL DML is finished! And then I execute this Sql, the Connection is Error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2410: [Feature][Connector-V2][JDBC] Support DB2 Source & Sink
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#issuecomment-1287234861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2410: [Connector-V2][JDBC-connector] support database: DB2
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#discussion_r945436368
##########
pom.xml:
##########
@@ -352,6 +353,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.ibm.db2</groupId>
+ <artifactId>jcc</artifactId>
+ <version>${db2.version}</version>
+ </dependency>
Review Comment:
These are two different things, for new connectors we don't need to publish binary packages, so we don't have to add these, for Jdbc we don't provide this dependency, so you need to change this dependency scope to `provide`. The meaning of `test` is too vague.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2410: [Connector-V2][JDBC-connector] support database: DB2
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#discussion_r947489934
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/db2/DB2DialectFactory.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.db2;
+
+
+import org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.JdbcDialect;
+import org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.JdbcDialectFactory;
+
+import com.google.auto.service.AutoService;
+
+/**
+ * Factory for {@link DB2Dialect}.
+ */
+
+@AutoService(JdbcDialectFactory.class)
+public class DB2DialectFactory implements JdbcDialectFactory {
+
+ @Override
+ public boolean acceptsURL(String url) {
+ return url.startsWith("jdbc:mysql:");
Review Comment:
Should be jdbc:db2: ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #2410: [Connector-V2][JDBC-connector] support database: DB2
Posted by GitBox <gi...@apache.org>.
ic4y commented on PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#issuecomment-1214563585
@laglangyue Wait for the JDBC e2e test (https://github.com/apache/incubator-seatunnel/pull/2321) to merge. You need to add test for DB2 in jdbc e2e test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2410: [Connector-V2][JDBC-connector] support database: DB2
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2410:
URL: https://github.com/apache/incubator-seatunnel/pull/2410#issuecomment-1222500421
this PR may be delay，I am finishing the DM. I spent some time studying the testcontainer，more of environment and DM images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org