Re: Implementing @OnWindowExpiration in StatefulParDo [BEAM-1589]

[Huygaa Batsaikhan <ba...@google.com>]

Finally, I have a PR <https://github.com/apache/beam/pull/4482> for the
annotation itself. Anyone up for reviewing it? Ken has been helping me, but
he is going to be OOO for a while.

On Tue, Mar 20, 2018 at 4:23 PM Huygaa Batsaikhan <ba...@google.com> wrote:

> As echauchot@ mentioned, it will make it easier and error-free.
>
>
> On Mon, Mar 19, 2018 at 11:59 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
>> Hi Huygaa,
>>
>> Cant it be predefined timers?
>>
>> Romain
>>
>> Le 20 mars 2018 00:52, "Huygaa Batsaikhan" <ba...@google.com> a écrit :
>>
>> Hi everyone, I am working on BEAM-1589
>> <https://issues.apache.org/jira/browse/BEAM-1589>. In short, currently,
>> there is no default way of saving/flushing state before a window is garbage
>> collected.
>>
>> My current plan is to provide a method annotation, @OnWindowExpiration,
>> which allows user-provided callback function to be executed before garbage
>> collection. This annotation behaves very similar to @OnTimer, therefore,
>> implementation will mostly be a copy of OnTimer code. Let me know if you
>> have any considerations and suggestions.
>>
>> Here is an example usage:
>> ```
>> @OnWindowExpiration
>> public void myCleanupFunction(OnWindowExpirationContext c, State state) {
>>   c.output(state.read());
>> }
>> ```
>>
>> Thanks, Huygaa
>>
>>
>>

Re: Implementing @OnWindowExpiration in StatefulParDo [BEAM-1589]

[Reuven Lax <re...@google.com>]

I can review it.

On Tue, Aug 14, 2018 at 10:26 AM Huygaa Batsaikhan <ba...@google.com>
wrote:

> Finally, I have a PR <https://github.com/apache/beam/pull/4482> for the
> annotation itself. Anyone up for reviewing it? Ken has been helping me, but
> he is going to be OOO for a while.
>
> On Tue, Mar 20, 2018 at 4:23 PM Huygaa Batsaikhan <ba...@google.com>
> wrote:
>
>> As echauchot@ mentioned, it will make it easier and error-free.
>>
>>
>> On Mon, Mar 19, 2018 at 11:59 PM Romain Manni-Bucau <
>> rmannibucau@gmail.com> wrote:
>>
>>> Hi Huygaa,
>>>
>>> Cant it be predefined timers?
>>>
>>> Romain
>>>
>>> Le 20 mars 2018 00:52, "Huygaa Batsaikhan" <ba...@google.com> a écrit :
>>>
>>> Hi everyone, I am working on BEAM-1589
>>> <https://issues.apache.org/jira/browse/BEAM-1589>. In short, currently,
>>> there is no default way of saving/flushing state before a window is garbage
>>> collected.
>>>
>>> My current plan is to provide a method annotation, @OnWindowExpiration,
>>> which allows user-provided callback function to be executed before garbage
>>> collection. This annotation behaves very similar to @OnTimer, therefore,
>>> implementation will mostly be a copy of OnTimer code. Let me know if you
>>> have any considerations and suggestions.
>>>
>>> Here is an example usage:
>>> ```
>>> @OnWindowExpiration
>>> public void myCleanupFunction(OnWindowExpirationContext c, State state) {
>>>   c.output(state.read());
>>> }
>>> ```
>>>
>>> Thanks, Huygaa
>>>
>>>
>>>