You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/04/20 07:36:39 UTC
[GitHub] [cassandra] jacek-lewandowski opened a new pull request #973: CASSANDRA-16618: Fix broken IntelliJ configuration
jacek-lewandowski opened a new pull request #973:
URL: https://github.com/apache/cassandra/pull/973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jacek-lewandowski closed pull request #973: CASSANDRA-16618: Fix broken IntelliJ configuration
Posted by GitBox <gi...@apache.org>.
jacek-lewandowski closed pull request #973:
URL: https://github.com/apache/cassandra/pull/973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jacek-lewandowski commented on a change in pull request #973: CASSANDRA-16618: Fix broken IntelliJ configuration
Posted by GitBox <gi...@apache.org>.
jacek-lewandowski commented on a change in pull request #973:
URL: https://github.com/apache/cassandra/pull/973#discussion_r616556077
##########
File path: ide/idea-iml-file.xml
##########
@@ -49,25 +49,27 @@
<orderEntry type="module-library">
<library>
<CLASSES>
- <root url="file://$MODULE_DIR$/lib" />
+ <root url="file://$MODULE_DIR$/build/lib/jars" />
</CLASSES>
Review comment:
ok, unfortunately we cannot remove `CLASSES` entries, IntelliJ would recognise it as an empty library :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request #973: CASSANDRA-16618: Fix broken IntelliJ configuration
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #973:
URL: https://github.com/apache/cassandra/pull/973#discussion_r616533296
##########
File path: ide/idea-iml-file.xml
##########
@@ -49,25 +49,27 @@
<orderEntry type="module-library">
<library>
<CLASSES>
- <root url="file://$MODULE_DIR$/lib" />
+ <root url="file://$MODULE_DIR$/build/lib/jars" />
</CLASSES>
Review comment:
do we need both `<CLASSES>` sections? (only jar files are found in `build/lib/jars` and `build/test/lib/jars`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] alex-ninja commented on pull request #973: CASSANDRA-16618: Fix broken IntelliJ configuration
Posted by GitBox <gi...@apache.org>.
alex-ninja commented on pull request #973:
URL: https://github.com/apache/cassandra/pull/973#issuecomment-851636787
Looks like this PR has been merged and can be closed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jacek-lewandowski commented on a change in pull request #973: CASSANDRA-16618: Fix broken IntelliJ configuration
Posted by GitBox <gi...@apache.org>.
jacek-lewandowski commented on a change in pull request #973:
URL: https://github.com/apache/cassandra/pull/973#discussion_r616537421
##########
File path: ide/idea-iml-file.xml
##########
@@ -49,25 +49,27 @@
<orderEntry type="module-library">
<library>
<CLASSES>
- <root url="file://$MODULE_DIR$/lib" />
+ <root url="file://$MODULE_DIR$/build/lib/jars" />
</CLASSES>
Review comment:
perhaps we do not, I've just taken the file generated by IntelliJ and those entries were there. I'll try if we can safely remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org