You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/05/30 00:33:24 UTC
[Impala-ASF-CR] Revert IMPALA-2751: Matching quotes are not requirerd in comments
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10537
Change subject: Revert IMPALA-2751: Matching quotes are not requirerd in comments
......................................................................
Revert IMPALA-2751: Matching quotes are not requirerd in comments
This patch is causing a large number of builds to fail, see
IMPALA-7089.
Change-Id: Id9995a91408d86a5ae1ecd70d07b02622ae26b43
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 5 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/10537/1
--
To view, visit http://gerrit.cloudera.org:8080/10537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9995a91408d86a5ae1ecd70d07b02622ae26b43
Gerrit-Change-Number: 10537
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] Revert IMPALA-2751: Matching quotes are not requirerd in comments
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10537 )
Change subject: Revert IMPALA-2751: Matching quotes are not requirerd in comments
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2567/
--
To view, visit http://gerrit.cloudera.org:8080/10537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9995a91408d86a5ae1ecd70d07b02622ae26b43
Gerrit-Change-Number: 10537
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 May 2018 04:40:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert IMPALA-2751: Matching quotes are not requirerd in comments
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10537 )
Change subject: Revert IMPALA-2751: Matching quotes are not requirerd in comments
......................................................................
Revert IMPALA-2751: Matching quotes are not requirerd in comments
This patch is causing a large number of builds to fail, see
IMPALA-7089.
Change-Id: Id9995a91408d86a5ae1ecd70d07b02622ae26b43
Reviewed-on: http://gerrit.cloudera.org:8080/10537
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 5 insertions(+), 25 deletions(-)
Approvals:
Philip Zeyliger: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9995a91408d86a5ae1ecd70d07b02622ae26b43
Gerrit-Change-Number: 10537
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] Revert IMPALA-2751: Matching quotes are not requirerd in comments
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10537 )
Change subject: Revert IMPALA-2751: Matching quotes are not requirerd in comments
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9995a91408d86a5ae1ecd70d07b02622ae26b43
Gerrit-Change-Number: 10537
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 May 2018 08:12:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert IMPALA-2751: Matching quotes are not requirerd in comments
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10537 )
Change subject: Revert IMPALA-2751: Matching quotes are not requirerd in comments
......................................................................
Patch Set 1: Code-Review+2
If this is a clean revert, let's do that first. There's no shame in reverts!
I think we've got a pause on new commits for build stabilization, so the unrevert is probably post-pause.
--
To view, visit http://gerrit.cloudera.org:8080/10537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9995a91408d86a5ae1ecd70d07b02622ae26b43
Gerrit-Change-Number: 10537
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 May 2018 03:44:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert IMPALA-2751: Matching quotes are not requirerd in comments
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10537 )
Change subject: Revert IMPALA-2751: Matching quotes are not requirerd in comments
......................................................................
Patch Set 1:
I'm making a fix for this right now. If the fix works, this should fix IMPALA-7089.
--
To view, visit http://gerrit.cloudera.org:8080/10537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9995a91408d86a5ae1ecd70d07b02622ae26b43
Gerrit-Change-Number: 10537
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 May 2018 03:30:33 +0000
Gerrit-HasComments: No