[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6494: Don't optimize AnalyzeExec (#6379) (try 2)

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6494:
URL: https://github.com/apache/arrow-datafusion/pull/6494#discussion_r1210829405


##########
datafusion/core/src/physical_plan/analyze.rs:
##########
@@ -121,96 +123,102 @@ impl ExecutionPlan for AnalyzeExec {
             )));
         }
 
-        // should be ensured by `SinglePartition`  above
-        let input_partitions = self.input.output_partitioning().partition_count();
-        if input_partitions != 1 {
-            return Err(DataFusionError::Internal(format!(
-                "AnalyzeExec invalid number of input partitions. Expected 1, got {input_partitions}"
-            )));
+        // Gather futures that will run each input partition using a
+        // JoinSet to cancel outstanding futures on drop
+        let mut set = JoinSet::new();

Review Comment:
   This uses the cool `JoinSet` I learned about from @nvartolomei  and @Darksonn  on https://github.com/apache/arrow-datafusion/pull/6449 ❤️ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org