You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ffbin <gi...@git.apache.org> on 2015/08/07 05:12:01 UTC
[GitHub] flink pull request: Fix StreamGraph getJobGraph bug
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/998
Fix StreamGraph getJobGraph bug
When forceCheckpoint is true,checkpointing will be enabled for iterative jobs.But now temporarily forbid checkpointing for iterative jobs, so if forceCheckpoint is true, will throw UnsupportedOperationException.
The old code logic is reversed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ffbin/flink FLINK-2494
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/998.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #998
----
commit 226354ccf3060e2d0c2ba4dd607bf83ce02735c1
Author: ffbin <86...@qq.com>
Date: 2015-08-07T02:41:55Z
Fix StreamGraph getJobGraph bug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2494 ]Fix StreamGraph getJobGraph bug
Posted by ffbin <gi...@git.apache.org>.
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/998#issuecomment-128642091
@zentol @gyfora Thank you very much.I have learn it.The code comment (// temporarily forbid checkpointing for iterative jobs) maybe is misleading.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2494 ]Fix StreamGraph getJobGraph bug
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/998#issuecomment-128670714
@ffbin If the issue has been resolved, could you please close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2494 ]Fix StreamGraph getJobGraph bug
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/998#issuecomment-128641012
If you read the message of the UnsupportedOperationException you'll find this bit:
> The user can force enable state checkpoints with the reduced guarantees by calling: env.enableCheckpointing(interval,true)
There is a little disparity here between the exception message and the comment, specifically the word "forbid" is probably the cause for this PR.
the comment could probably be removed as the exception msg is sufficient to explain the current behaviour. imho this would be kinda unnecessary though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2494 ]Fix StreamGraph getJobGraph bug
Posted by ffbin <gi...@git.apache.org>.
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/998#issuecomment-128610658
enableCheckpointing() will call forceCheckpoint() and set forceCheckpoint true.The old code(if (isIterative() && isCheckpointingEnabled() && !forceCheckpoint) ) will not throw UnsupportedOperationException when enable checkpointing for iterative job.So we should change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2494 ]Fix StreamGraph getJobGraph bug
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/998#issuecomment-128624595
I believe you are wrong, check: IterateTest#testWithCheckpointing()
I think that tests for the mentioned case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2494 ]Fix StreamGraph getJobGraph bug
Posted by ffbin <gi...@git.apache.org>.
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/998#issuecomment-128637022
@gyfora Thanks.
I have check IterateTest#testWithCheckpointing(), it is for the mentioned case.
But the comment (// temporarily forbid checkpointing for iterative jobs) in getJobGraph() means that when use checkpointing for iterative jobs should throw UnsupportedOperationException.
I have debug the IterateTest#testWithCheckpointing() , it do not throw any Exception.
Can you tell me why? Thank you very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2494 ]Fix StreamGraph getJobGraph bug
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/998#issuecomment-128605743
i would assume that forceCheckpoint is supposed to do exactly that, enforce checkpointing regardless of its support.
this change also means that if checkPointint is enabled, but not forced, the job will not hit an UnsupportedOperationException, which doesn't make any sense whatsoever.
-1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2494 ]Fix StreamGraph getJobGraph bug
Posted by ffbin <gi...@git.apache.org>.
Github user ffbin closed the pull request at:
https://github.com/apache/flink/pull/998
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---