You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/02 02:31:49 UTC
[GitHub] [shardingsphere] dongzl opened a new pull request, #20724: Optimize code, remove unused method param.
dongzl opened a new pull request, #20724:
URL: https://github.com/apache/shardingsphere/pull/20724
For #20681
Changes proposed in this pull request:
- Optimize code, remove unused method param.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #20724: Optimize code, remove unused method param.
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #20724:
URL: https://github.com/apache/shardingsphere/pull/20724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20724: Optimize code, remove unused method param.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20724:
URL: https://github.com/apache/shardingsphere/pull/20724#issuecomment-1235026467
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20724](https://codecov.io/gh/apache/shardingsphere/pull/20724?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0c00930) into [master](https://codecov.io/gh/apache/shardingsphere/commit/dfee6d93a66fa3c94e85f1d8c9fa5b08328a7207?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfee6d9) will **increase** coverage by `0.02%`.
> The diff coverage is `70.40%`.
> :exclamation: Current head 0c00930 differs from pull request most recent head f15f3f1. Consider uploading reports for the commit f15f3f1 to get more accurate results
```diff
@@ Coverage Diff @@
## master #20724 +/- ##
============================================
+ Coverage 61.04% 61.07% +0.02%
- Complexity 2414 2416 +2
============================================
Files 3964 3968 +4
Lines 55086 55167 +81
Branches 9351 9367 +16
============================================
+ Hits 33627 33691 +64
- Misses 18595 18608 +13
- Partials 2864 2868 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20724?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvY29yZS9rZXJuZWwvS2VybmVsRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../distsql/parser/core/TransactionDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/20724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtdHJhbnNhY3Rpb24tZGlzdHNxbC1wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL2Rpc3RzcWwvcGFyc2VyL2NvcmUvVHJhbnNhY3Rpb25EaXN0U1FMUGFyc2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...arser/core/TransactionDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtdHJhbnNhY3Rpb24tZGlzdHNxbC1wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL2Rpc3RzcWwvcGFyc2VyL2NvcmUvVHJhbnNhY3Rpb25EaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...acade/TransactionDistSQLStatementParserFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/20724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtdHJhbnNhY3Rpb24tZGlzdHNxbC1wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL2Rpc3RzcWwvcGFyc2VyL2ZhY2FkZS9UcmFuc2FjdGlvbkRpc3RTUUxTdGF0ZW1lbnRQYXJzZXJGYWNhZGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../handler/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/20724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `75.55% <ø> (+3.21%)` | :arrow_up: |
| [...tsql/ral/UpdatableGlobalRuleRALBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1VwZGF0YWJsZUdsb2JhbFJ1bGVSQUxCYWNrZW5kSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ler/distsql/ral/updatable/ApplyDistSQLHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9BcHBseURpc3RTUUxIYW5kbGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...r/distsql/ral/updatable/DiscardDistSQLHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9EaXNjYXJkRGlzdFNRTEhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...r/distsql/ral/updatable/PrepareDistSQLHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9QcmVwYXJlRGlzdFNRTEhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../distsql/ral/impl/QueryableRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/20724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC9RdWVyeWFibGVSQUxTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `96.55% <ø> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/shardingsphere/pull/20724/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org