[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2178: Improve query performance with HBase

["imbajin (via GitHub)" <gi...@apache.org>]

imbajin commented on code in PR #2178:
URL: https://github.com/apache/incubator-hugegraph/pull/2178#discussion_r1148387796


##########
hugegraph-hbase/src/main/java/org/apache/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -418,7 +419,11 @@ default R scan(String table, Set<byte[]> prefixes) {
          */
         default R scan(String table, byte[] startRow, boolean inclusiveStart,
                        byte[] prefix) {
+            short value = (short) (((startRow[0] << 8) | (startRow[1] & 0xFF)) +1);
+            byte[] endRow = ByteBuffer.allocate(2).putShort(value).array();

Review Comment:
   not quiet clear with it，could u explain it more？
   
   and for any of the scan query condition，we always add the end-row？
   
   could u give a case for it（before vs after），and check the ci problems
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org