You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Eric Milles (Jira)" <ji...@apache.org> on 2023/02/01 23:32:00 UTC

[jira] [Updated] (GROOVY-10909) bytecode for in, !in, !() and ?:

     [ https://issues.apache.org/jira/browse/GROOVY-10909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Milles updated GROOVY-10909:
---------------------------------
    Fix Version/s: 5.0.0-alpha-1

> bytecode for in, !in, !() and ?:
> --------------------------------
>
>                 Key: GROOVY-10909
>                 URL: https://issues.apache.org/jira/browse/GROOVY-10909
>             Project: Groovy
>          Issue Type: Improvement
>          Components: bytecode, Compiler, Static compilation
>            Reporter: Eric Milles
>            Assignee: Eric Milles
>            Priority: Minor
>              Labels: bytecode
>             Fix For: 5.0.0-alpha-1
>
>
> Consider the following:
> {code:groovy}
> List getList() { ['xx'] }
> @groovy.transform.CompileStatic
> void test(object) {
>   def others = [], strings = []
>   if (object in list) { // 4 of 8 branches missed
>     strings << object
>   }
>   if (!(object in list)) { // 4 of 10 branched missed
>     others << object
>   }
>   println others
>   println strings
> }
> test(null)
> test('xx')
> test([''])
> {code}
> When unit testing, I noticed 4 of 10 branches missed for "if (!(item in list)) ...".  When compiled and executed dynamically, it shows 2 of 2 branches covered (safe call to "list.isCase(item)").
> Static compilation transforms "item in list" into "list == null ? item == null : list.isCase(item)".  This is certainly where all the branches are coming from.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)