You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/02 22:09:49 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #1994: Use slim docker image
viirya opened a new pull request, #1994:
URL: https://github.com/apache/arrow-rs/pull/1994
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1993.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1994:
URL: https://github.com/apache/arrow-rs/pull/1994#issuecomment-1172984507
cc @alamb @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1994:
URL: https://github.com/apache/arrow-rs/pull/1994#issuecomment-1173007256
Finally works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1994:
URL: https://github.com/apache/arrow-rs/pull/1994#discussion_r915045738
##########
.github/workflows/rust.yml:
##########
@@ -76,44 +84,54 @@ jobs:
- name: Run tests
run: |
# run tests on all workspace members with default feature list
+ cargo clean
cargo test
- name: Re-run tests with all supported features
run: |
+ cargo clean
cargo test -p arrow --features=force_validate,prettyprint
- name: Run examples
run: |
+ cargo clean
Review Comment:
I saw many times running out of disk space recently in CI. `Rust / Test Workspace on AMD64 Rust stable (pull_request) Successful in 34m` seems not too slow to me. But I'm fine to skip this change if you think it is too long to run CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1994:
URL: https://github.com/apache/arrow-rs/pull/1994#issuecomment-1172978089
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1994?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1994](https://codecov.io/gh/apache/arrow-rs/pull/1994?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f20244) into [master](https://codecov.io/gh/apache/arrow-rs/commit/ccddaa83c989c23c9af819b2dc60c47dd0abe526?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ccddaa8) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1994 +/- ##
=======================================
Coverage 83.57% 83.58%
=======================================
Files 221 222 +1
Lines 57482 57495 +13
=======================================
+ Hits 48043 48057 +14
+ Misses 9439 9438 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...row/src/array/builder/string\_dictionary\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvc3RyaW5nX2RpY3Rpb25hcnlfYnVpbGRlci5ycw==) | `91.36% <0.00%> (-0.37%)` | :arrow_down: |
| [arrow/src/array/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L21vZC5ycw==) | `100.00% <0.00%> (ø)` | |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (ø)` | |
| [arrow/src/array/array\_decimal.rs](https://codecov.io/gh/apache/arrow-rs/pull/1994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2RlY2ltYWwucnM=) | `93.67% <0.00%> (ø)` | |
| [arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow-rs/pull/1994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X3ByaW1pdGl2ZS5ycw==) | `95.81% <0.00%> (+0.03%)` | :arrow_up: |
| [arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow-rs/pull/1994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X3N0cmluZy5ycw==) | `97.76% <0.00%> (+0.03%)` | :arrow_up: |
| [arrow/src/array/data.rs](https://codecov.io/gh/apache/arrow-rs/pull/1994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2RhdGEucnM=) | `84.54% <0.00%> (+0.13%)` | :arrow_up: |
| [arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow-rs/pull/1994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2JpbmFyeS5ycw==) | `94.20% <0.00%> (+0.16%)` | :arrow_up: |
| [arrow/src/array/builder/primitive\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvcHJpbWl0aXZlX2J1aWxkZXIucnM=) | `93.11% <0.00%> (+0.32%)` | :arrow_up: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `65.79% <0.00%> (+0.37%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/arrow-rs/pull/1994/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1994?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1994?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ccddaa8...3f20244](https://codecov.io/gh/apache/arrow-rs/pull/1994?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1994:
URL: https://github.com/apache/arrow-rs/pull/1994#discussion_r915045738
##########
.github/workflows/rust.yml:
##########
@@ -76,44 +84,54 @@ jobs:
- name: Run tests
run: |
# run tests on all workspace members with default feature list
+ cargo clean
cargo test
- name: Re-run tests with all supported features
run: |
+ cargo clean
cargo test -p arrow --features=force_validate,prettyprint
- name: Run examples
run: |
+ cargo clean
Review Comment:
I saw many times running out of disk space recently in CI. `Rust / Test Workspace on AMD64 Rust stable (pull_request) Successful in 34m` seems no too slow to me. But I'm fine to skip this change if you think it is too long to run CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1994:
URL: https://github.com/apache/arrow-rs/pull/1994#issuecomment-1176784903
Not sure why, but recent CI runs don't show out of disk space error. I'm going to close this PR. Thanks @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1994:
URL: https://github.com/apache/arrow-rs/pull/1994#discussion_r913685979
##########
.github/workflows/rust.yml:
##########
@@ -76,44 +84,54 @@ jobs:
- name: Run tests
run: |
# run tests on all workspace members with default feature list
+ cargo clean
cargo test
- name: Re-run tests with all supported features
run: |
+ cargo clean
cargo test -p arrow --features=force_validate,prettyprint
- name: Run examples
run: |
+ cargo clean
Review Comment:
This seems unfortunate as it will clear out the prior build state as well as all the caches.
I wonder if perhaps something else is going on here, perhaps the caches have grown to some stupid size or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1994:
URL: https://github.com/apache/arrow-rs/pull/1994#issuecomment-1172990191
A new error which is also related to device space.
```
Unhandled exception. System.IO.IOException: No space left on device : '/home/runner/runners/2.294.0/_diag/Worker_20220703-010420-utc.log'
at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
at System.IO.Strategies.BufferedFileStreamStrategy.FlushWrite()
at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
at System.Diagnostics.TextWriterTraceListener.Flush()
at System.Diagnostics.TraceSource.Flush()
at GitHub.Runner.Common.TraceManager.Dispose(Boolean disposing)
at GitHub.Runner.Common.TraceManager.Dispose()
at GitHub.Runner.Common.HostContext.Dispose(Boolean disposing)
at GitHub.Runner.Common.HostContext.Dispose()
at GitHub.Runner.Worker.Program.Main(String[] args)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1994:
URL: https://github.com/apache/arrow-rs/pull/1994#discussion_r914843134
##########
.github/workflows/rust.yml:
##########
@@ -76,44 +84,54 @@ jobs:
- name: Run tests
run: |
# run tests on all workspace members with default feature list
+ cargo clean
cargo test
- name: Re-run tests with all supported features
run: |
+ cargo clean
cargo test -p arrow --features=force_validate,prettyprint
- name: Run examples
run: |
+ cargo clean
Review Comment:
The runners should have access to 14GB of disk space, so this should be fine... The CI is already painfully slow, I'm not particularly excited about making it even slower...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1994:
URL: https://github.com/apache/arrow-rs/pull/1994#discussion_r914010829
##########
.github/workflows/rust.yml:
##########
@@ -76,44 +84,54 @@ jobs:
- name: Run tests
run: |
# run tests on all workspace members with default feature list
+ cargo clean
cargo test
- name: Re-run tests with all supported features
run: |
+ cargo clean
cargo test -p arrow --features=force_validate,prettyprint
- name: Run examples
run: |
+ cargo clean
Review Comment:
The build state in `target` is quite large. I observed 3xG locally. It is very easy to run out of disk space in next builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1994:
URL: https://github.com/apache/arrow-rs/pull/1994#discussion_r914010829
##########
.github/workflows/rust.yml:
##########
@@ -76,44 +84,54 @@ jobs:
- name: Run tests
run: |
# run tests on all workspace members with default feature list
+ cargo clean
cargo test
- name: Re-run tests with all supported features
run: |
+ cargo clean
cargo test -p arrow --features=force_validate,prettyprint
- name: Run examples
run: |
+ cargo clean
Review Comment:
The build state in `target` is quite large. I observed 3xG locally. Without cleaning it up, it is very easy to run out of disk space in next builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya closed pull request #1994: Use slim docker image
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #1994: Use slim docker image
URL: https://github.com/apache/arrow-rs/pull/1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org