[jira] [Commented] (AMQ-5055) Webconsole copy of message keeps message ID and leads to failures

["Arthur Naseef (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915438#comment-13915438 ] 

Arthur Naseef commented on AMQ-5055:
------------------------------------

Tracking the code path, it appears BrokerSupport.doResend() is used to copy and resend the message.

Even though the message is copied, the message id is not changed.  Is it safe to modify that method to change the message id after copying?  What use-case exists for keeping the same message id?

> Webconsole copy of message keeps message ID and leads to failures
> -----------------------------------------------------------------
>
>                 Key: AMQ-5055
>                 URL: https://issues.apache.org/jira/browse/AMQ-5055
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker, webconsole
>         Environment: activemq-5.10-SNAPSHOT up to commit ec249f4dac29b0b566703b9235f25aacfa2b6ac6
>            Reporter: Arthur Naseef
>            Assignee: Arthur Naseef
>            Priority: Minor
>
> Using the webconsole copy option for a persistent message to copy the message more than once to the same destination queue leads to problems.
> The second copy of the message will increase the Queue size and enqueue counter, but does not actually place a message in the Queue, whether or not the earlier copy is still in the Queue.  In addition, the following error message is logged by the broker.
> {noformat}
>  WARN | duplicate message from store ID:Arthur-Naseefs-MacBook-Pro.local-61946-1392522408304-3:2:1:1:3, redirecting for dlq processing
> {noformat}
> Note that this was not tested across broker restarts.  Non-Persistent messages do not appear to have this problem.
> It seems that maintaining the message ID across copies is causing problems.
> Creating a completely new message ID should be the simplest solution.  Perhaps storing the original message ID in a property (e.g. JMSXSourceMessageId) on the new message would be useful in case anyone wants to be able to detect the copy and determine from which message it was created.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)