You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Alexander L (Jira)" <ji...@apache.org> on 2021/05/25 03:10:00 UTC

[jira] [Updated] (LUCENE-9971) SortedSetDocValuesFacetCounts throws exception in case of unseen dimension (unlike other Facet implementations)

     [ https://issues.apache.org/jira/browse/LUCENE-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander L updated LUCENE-9971:
--------------------------------
    Description: 
Unlike other org.apache.lucene.facet.Facet interface implementations, SortedSetDocValuesFacetCounts and ConcurrentSortedSetDocValuesFacetCounts [throw an exception in case of unseen dimension in the getTopChildren() method |https://github.com/apache/lucene/blob/main/lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java#L99] 

It is inconsistent with [Facet interface documentation|https://github.com/apache/lucene/blob/main/lucene/facet/src/java/org/apache/lucene/facet/Facets.java#L33] and not pleasant to deal with: in our case requested dimensions can be manually specified by the user, so we should always catch that and check the exception message to be sure of the exact cause.

  was:
Unlike other org.apache.lucene.facet.Facet interface implementations, SortedSetDocValuesFacetCounts and ConcurrentSortedSetDocValuesFacetCounts [throw an exception in case of unseen dimension in the getTopChildren() method|[https://github.com/apache/lucene/blob/main/lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java#L99].] 

It is inconsistent with [Facet interface documentation|https://github.com/apache/lucene/blob/main/lucene/facet/src/java/org/apache/lucene/facet/Facets.java#L33] and not pleasant to deal with: in our case requested dimensions can be manually specified by the user, so we should always catch that and check the exception message to be sure of the exact cause.


> SortedSetDocValuesFacetCounts throws exception in case of unseen dimension (unlike other Facet implementations)
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-9971
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9971
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alexander L
>            Priority: Minor
>
> Unlike other org.apache.lucene.facet.Facet interface implementations, SortedSetDocValuesFacetCounts and ConcurrentSortedSetDocValuesFacetCounts [throw an exception in case of unseen dimension in the getTopChildren() method |https://github.com/apache/lucene/blob/main/lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java#L99] 
> It is inconsistent with [Facet interface documentation|https://github.com/apache/lucene/blob/main/lucene/facet/src/java/org/apache/lucene/facet/Facets.java#L33] and not pleasant to deal with: in our case requested dimensions can be manually specified by the user, so we should always catch that and check the exception message to be sure of the exact cause.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org