You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Xiaomeng Huang <xi...@intel.com> on 2014/08/22 07:31:45 UTC
Review Request 24960: SENTRY-389: Database implementation for column
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24960/
-----------------------------------------------------------
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Repository: sentry
Description
-------
Add a filed "column" to privilege
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java 5328fff
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo b39cb18
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.4.0.sql c1a2778
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.4.0.sql c1a2778
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.4.0.sql d7ce57c
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.4.0.sql 3f01cda
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.4.0.sql 186c968
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreToAuthorizable.java d77786a
Diff: https://reviews.apache.org/r/24960/diff/
Testing
-------
Thanks,
Xiaomeng Huang
Re: Review Request 24960: SENTRY-389: Database implementation for
column
Posted by Xiaomeng Huang <xi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24960/
-----------------------------------------------------------
(Updated Sept. 9, 2014, 9:47 a.m.)
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Changes
-------
rebase this patch based on https://reviews.apache.org/r/25472/ (Add upgrade scripts for column level privileges)
Repository: sentry
Description
-------
Add a filed "column" to privilege
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java 5328fff
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo b39cb18
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreToAuthorizable.java d77786a
Diff: https://reviews.apache.org/r/24960/diff/
Testing
-------
Thanks,
Xiaomeng Huang
Re: Review Request 24960: SENTRY-389: Database implementation for
column
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24960/#review52641
-----------------------------------------------------------
Ship it!
The patch itself looks fine to me.
We need to add schema upgrade scripts for migrating older release sentry store schema to this new format. SENTRY-407 which adds the base scripts and framework for handling the schema upgrade. Please file a followup ticket to add the upgrade after SENTRY-407 is committed.
- Prasad Mujumdar
On Aug. 22, 2014, 5:31 a.m., Xiaomeng Huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24960/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 5:31 a.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add a filed "column" to privilege
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java 5328fff
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo b39cb18
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.4.0.sql c1a2778
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.4.0.sql c1a2778
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.4.0.sql d7ce57c
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.4.0.sql 3f01cda
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.4.0.sql 186c968
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreToAuthorizable.java d77786a
>
> Diff: https://reviews.apache.org/r/24960/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xiaomeng Huang
>
>