[GitHub] [bookkeeper] rdhabalia commented on a change in pull request #2964: Skip update entryLogMetaMap if not modified

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #2964:
URL: https://github.com/apache/bookkeeper/pull/2964#discussion_r778488908



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
##########
@@ -462,16 +463,23 @@ private void doGcEntryLogs() throws EntryLogMetadataMapException {
         this.numActiveEntryLogs = entryLogMetaMap.size();
     }
 
-    private void removeIfLedgerNotExists(EntryLogMetadata meta) throws EntryLogMetadataMapException {
+    private boolean removeIfLedgerNotExists(EntryLogMetadata meta) throws EntryLogMetadataMapException {
+        AtomicBoolean modified = new AtomicBoolean(false);

Review comment:
       you can use light weight `MutableBoolean` instead `AtomicBoolean`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org