[GitHub] NamanRastogi edited a comment on issue #3064: [CARBONDATA-3243] Updated DOC for No-Sort Compaction and a few Fixes

[GitBox <gi...@apache.org>]

NamanRastogi edited a comment on issue #3064: [CARBONDATA-3243] Updated DOC for No-Sort Compaction and a few Fixes
URL: https://github.com/apache/carbondata/pull/3064#issuecomment-455970559
 
 
   @xuchuanyin I have removed the Explanation of Compaction Performance. But Document update is still required for `SET ALTER.TABLE.LOAD.SORT.SCOPE.<database>.<table>` and Sort-Scope in `LOAD DATA` command.
   
   Problems:
   1. **SortScopeOptions.getSortScope**
       Default Sort Scope after [PR 2966](https://github.com/apache/carbondata/pull/2966) is NO_SORT. So default here also should be Default Sort Scope, not some hardcoded value.
   
   2. **CarbonTable.getSortScope**
       After [PR 3014](https://github.com/apache/carbondata/pull/3014), session property for table level sort scope is added. This overrides the table level Sort Scope provided in `CREATE TABLE` command. CarbonTable.getSortScope should also reflect this behavior.
   
   3. **CarbonDDLSqlParser.validateOptions**
       The Sort Scope for Load Data command was not getting verified.
   
   4. **SingleThreadFinalSortFilesMerger.getSortScope**
       Object `inMemorySortTempChunkHolder` should be added to the `recordHolderHeapLocal` Only if a row is found in `inMemorySortTempChunkHolder`, else not.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services