You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "marcingrzejszczak (via GitHub)" <gi...@apache.org> on 2023/03/20 11:52:30 UTC
[GitHub] [camel] marcingrzejszczak opened a new pull request, #9583: Not setting events for log methods on routes
marcingrzejszczak opened a new pull request, #9583:
URL: https://github.com/apache/camel/pull/9583
without this change we are always creating an event when a log happens within a route. That corresponds to a log on a span and a counter on a metrics. The log statement is arbitrary and logs on spans should be meaningful and short in name. Same thing for metric names that should of super low cardinality. Since we can't ensure that the log statement follows these requirements (nor should we) we think that we should not set those entries on spans and create such counters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #9583: Not setting events for log methods on routes
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #9583:
URL: https://github.com/apache/camel/pull/9583#issuecomment-1479935957
Once this https://github.com/apache/camel/pull/9584 gets merged I can apply changes from this and that PR together (actually the latter PR contains changes from this PR too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9583: Not setting events for log methods on routes
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9583:
URL: https://github.com/apache/camel/pull/9583#issuecomment-1476154258
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #9583: Not setting events for log methods on routes
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #9583:
URL: https://github.com/apache/camel/pull/9583#issuecomment-1479312147
Yes, I will send PRs to all branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #9583: Not setting events for log methods on routes
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #9583:
URL: https://github.com/apache/camel/pull/9583#issuecomment-1476119220
There's a checkstyle issue but I don't think I caused it (or did I?)
```
[ERROR] Failed to execute goal on project camel-dhis2: Could not resolve dependencies for project org.apache.camel:camel-dhis2:jar:3.21.0-SNAPSHOT: Could not find artifact org.apache.camel:camel-dhis2-api:jar:3.21.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots/) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project camel-dhis2: Could not resolve dependencies for project org.apache.camel:camel-dhis2:jar:3.21.0-SNAPSHOT: Could not find artifact org.apache.camel:camel-dhis2-api:jar:3.21.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots/)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9583: Not setting events for log methods on routes
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9583:
URL: https://github.com/apache/camel/pull/9583#issuecomment-1479308602
can you send PR for main branch also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9583: Not setting events for log methods on routes
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9583:
URL: https://github.com/apache/camel/pull/9583#issuecomment-1476121092
Not your fault :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9583: Not setting events for log methods on routes
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9583:
URL: https://github.com/apache/camel/pull/9583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9583: Not setting events for log methods on routes
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9583:
URL: https://github.com/apache/camel/pull/9583#issuecomment-1476086581
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org