You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/11 04:15:19 UTC

[GitHub] [incubator-doris] cambyzju opened a new pull request, #8949: [feature-wip](array-type) permute impl for column array

cambyzju opened a new pull request, #8949:
URL: https://github.com/apache/incubator-doris/pull/8949

   # Proposed changes
   
   Issue Number: close #7570
   
   ## Problem Summary:
   
   Change1: permute implement
   While select with Array column and order by other column, permute will be called.
   So we need to implement permute for Array Column.
   
   For example, before permute implement, the following SQL will failed.
   ```
   > select * from array_test order by k1;
   +------+------+--------+
   | k1   | k2   | k3     |
   +------+------+--------+
   |    1 |    2 | [1, 2] |
   |    2 |    3 | NULL   |
   |    3 | NULL | NULL   |
   |    4 | NULL | []     |
   +------+------+--------+
   ```
   
   Change2: column array codes format
   
   Change3: UT added for ColumnArray::permute
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8949: [feature-wip](array-type) permute impl for column array

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8949:
URL: https://github.com/apache/incubator-doris/pull/8949#issuecomment-1094633112

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yiguolei merged pull request #8949: [feature-wip](array-type) permute impl for column array

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #8949:
URL: https://github.com/apache/incubator-doris/pull/8949


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8949: [feature-wip](array-type) permute impl for column array

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8949:
URL: https://github.com/apache/incubator-doris/pull/8949#issuecomment-1094633075

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org