[jira] Commented: (HADOOP-4768) Dynamic Priority Scheduler that allows queue shares to be controlled dynamically by a currency

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708919#action_12708919 ] 

Steve Loughran commented on HADOOP-4768:
----------------------------------------

Thomas, I've had a look at this

-general: check the line endings stop at the hadoop recommended length,
have the right spaces and indentation

-could you have the mapred conf strings defined as constants in a single interface or class (with static imports)?

-do we have to have everything in the org.apache.hadoop.mapred package? I know that the scheduler
 needs to be there, but it would be cleaner if we had a dynamic package for everything other than
 the scheduler to go. Of course, it it depends on the access rights of whichever mapred classes
 get passed around

-QueueAllocation: should the fields be private?

-FileAllocationStore.save should always close() the output stream
If there is an exception saving, the filename should be printed as well
as the exception. Same for the load; the close() should be in a finally clause

-tests should use assertEquals() for better errors
This is critical for those
that use floating point numbers, as they should include an
allowed range for the values

-TEST_DIR should be set up in the test setUp(),
in case test runners set system properties on a 
test-by-test basis.

-Lots of commonality in the test cases -could that be
factored out into a base class for lower maintenance?

-removeQueues() operations should be in the teardown so that 
they run even if the tests fail (though you may need an empty test to see what happens if you try to remove a queue that was never created)

-Consider adding tests for the PriorityScheduler comparators 
-consider test for the PriorityScheduler authorize logic

> Dynamic Priority Scheduler that allows queue shares to be controlled dynamically by a currency
> ----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-4768
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4768
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: contrib/capacity-sched, contrib/fair-share
>    Affects Versions: 0.21.0
>            Reporter: Thomas Sandholm
>            Assignee: Thomas Sandholm
>         Attachments: HADOOP-4768-2.patch, HADOOP-4768-capacity-scheduler.patch, HADOOP-4768-dynamic-scheduler.patch, HADOOP-4768-fairshare.patch, HADOOP-4768.patch
>
>
> Dynamic (economic) priority scheduler based on work presented at the Hadoop User Group meeting in Santa Clara in September and the HadoopCamp in New Orleans in November 2008.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.