You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2022/10/02 13:49:40 UTC
Review Request 74149: RANGER-3804: Update policy UI to support multiple resource-sets
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74149/
-----------------------------------------------------------
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-3804
https://issues.apache.org/jira/browse/RANGER-3804
Repository: ranger
Description
-------
Policy model enhancements in RANGER_3796 enable a Ranger policy to be created with multiple resource-sets – like:
database: [ db1 ], table: [ tbl1 ], column: [ * ]
database: [ db1 ], udf: [ * ]
database: [ db2 ], table: [ tbl2 ], column: [ * ]
Policy UI needs to be updated to support multiple resource-sets, some what similar to security-zone UI that allows multiple resource-sets to be added in a zone. For policy UI, I suggest retaining existing UI for RangerPolicy.resources, and have a separate optional UI (triggered via More Resources button?) to capture additional resources.
Diffs
-----
security-admin/src/main/webapp/scripts/modules/XAOverrides.js 9237abdb4
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 28f05ae5e
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 65c4f66b8
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js a672648b4
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js ba94e6f53
security-admin/src/main/webapp/scripts/views/policies/ResourceList.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/security_zone/ZoneResourceForm.js 900d9da6e
security-admin/src/main/webapp/scripts/views/service/ServiceAuditFilterResources.js 683fa4b18
security-admin/src/main/webapp/styles/xa.css 2da2f29b7
security-admin/src/main/webapp/templates/helpers/XAHelpers.js e466f62c9
security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html e314e83eb
security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 1edfe240f
security-admin/src/main/webapp/templates/policies/ResourceItem_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/ResourceList_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/security_zone/ZoneResourcesForm_tmpl.html d3ed5aba1
Diff: https://reviews.apache.org/r/74149/diff/1/
Testing
-------
Verified for access, masking and row filter policy
1. Policy CRUD for all services with single resource
2. Policy CRUD for all services with multiple resource
3. Policy CRUD for tag based policy with single resource
4. Policy CRUD for tag based policy with multiple resource
5. Policy view popup with single resource
6. Policy view popup with multiple resource
Thanks,
Nitin Galave
Re: Review Request 74149: RANGER-3804: Update policy UI to support multiple resource-sets
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74149/#review224727
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 2, 2022, 1:49 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74149/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2022, 1:49 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3804
> https://issues.apache.org/jira/browse/RANGER-3804
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Policy model enhancements in RANGER_3796 enable a Ranger policy to be created with multiple resource-sets – like:
>
> database: [ db1 ], table: [ tbl1 ], column: [ * ]
> database: [ db1 ], udf: [ * ]
> database: [ db2 ], table: [ tbl2 ], column: [ * ]
>
>
> Policy UI needs to be updated to support multiple resource-sets, some what similar to security-zone UI that allows multiple resource-sets to be added in a zone. For policy UI, I suggest retaining existing UI for RangerPolicy.resources, and have a separate optional UI (triggered via More Resources button?) to capture additional resources.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/XAOverrides.js 9237abdb4
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 28f05ae5e
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 65c4f66b8
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js a672648b4
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js ba94e6f53
> security-admin/src/main/webapp/scripts/views/policies/ResourceList.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/security_zone/ZoneResourceForm.js 900d9da6e
> security-admin/src/main/webapp/scripts/views/service/ServiceAuditFilterResources.js 683fa4b18
> security-admin/src/main/webapp/styles/xa.css 2da2f29b7
> security-admin/src/main/webapp/templates/helpers/XAHelpers.js e466f62c9
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html e314e83eb
> security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 1edfe240f
> security-admin/src/main/webapp/templates/policies/ResourceItem_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/ResourceList_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/security_zone/ZoneResourcesForm_tmpl.html d3ed5aba1
>
>
> Diff: https://reviews.apache.org/r/74149/diff/1/
>
>
> Testing
> -------
>
> Verified for access, masking and row filter policy
>
> 1. Policy CRUD for all services with single resource
> 2. Policy CRUD for all services with multiple resource
> 3. Policy CRUD for tag based policy with single resource
> 4. Policy CRUD for tag based policy with multiple resource
> 5. Policy view popup with single resource
> 6. Policy view popup with multiple resource
>
>
> Thanks,
>
> Nitin Galave
>
>