[GitHub] guacamole-server pull request #180: GUACAMOLE-610: Add support for changing ...

[mike-jumper <gi...@git.apache.org>]

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/guacamole-server/pull/180

    GUACAMOLE-610: Add support for changing scrollback buffer size.

    These changes allow the scrollback buffer size for SSH and telnet to be changed through two mechanisms:
    
    1. A new connection parameter (`scrollback`) which sets the initial scrollback size and functions as an upper limit.
    2. A new Guacamole-specific console code which requests the scrollback size be changed. The terminal emulator may ignore this value if the upper limit set via connection parameters is lower than the requested value, or if the size of the terminal requires additional buffer space. The `guacctl` utility has been modified to provide a `-S` option to allow the console code to be sent conveniently.
    
    It's important to note that, like other terminal emulators, the Guacamole terminal emulator uses the same buffer space to back the active display area and the off-screen region considered "scrollback". The number of off-screen rows which remain accessible to scrolling is thus the size of the scrollback buffer less the size of the display.
    
    As the buffer must always contain enough space for the contents of the display, the maximum scrollback size is overridden as necessary to ensure the display is visible. This is accomplished through establishing an upper limit on the terminal display size (1024 rows) and ensuring the buffer always has at least this many rows, with the requested limit only affecting whether these rows are accessible when scrolling, not whether the rows are in memory at all.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/guacamole-server scrollback-param

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-server/pull/180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #180
    
----
commit 6a576f012184b9c2dba9117ad870cab1bd012818
Author: Michael Jumper <mj...@...>
Date:   2018-08-13T05:37:24Z

    GUACAMOLE-610: Limit terminal width/height to 1024 characters.

commit 0e6d549a40eaf4ddfa58cdb433c7815a51b82988
Author: Michael Jumper <mj...@...>
Date:   2018-08-13T07:48:46Z

    GUACAMOLE-610: Allow scrollback size to be specified for SSH and telnet.

commit 994cb95893aa1e136626b5ec4bdd4c4d22d044f5
Author: Michael Jumper <mj...@...>
Date:   2018-08-13T07:50:05Z

    GUACAMOLE-610: Add console code for altering scrollback size on the fly.

----


---

[GitHub] guacamole-server pull request #180: GUACAMOLE-610: Add support for changing ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/guacamole-server/pull/180


---