[jira] [Commented] (OAK-8763) LoginContextProviderImpl uses any subject found in the AccessControlContext.

["Manfred Baedke (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987895#comment-16987895 ] 

Manfred Baedke commented on OAK-8763:
-------------------------------------

[~angela],

bq. IMO the repository must not mandate how a pre-authenticated subject is generated

Agreed, but I don't know if the issue is completely solved. Note that the incoming subject is readonly, so we will fail to add any credentials or principals on login. I would expect that to cause authorization issues, but did not verify. I guess you can tell immediately.

> LoginContextProviderImpl uses any subject found in the AccessControlContext.
> ----------------------------------------------------------------------------
>
>                 Key: OAK-8763
>                 URL: https://issues.apache.org/jira/browse/OAK-8763
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: security-spi
>            Reporter: Manfred Baedke
>            Assignee: Angela Schreiber
>            Priority: Minor
>         Attachments: OAK-8763-tests.patch, OAK-8763.patch
>
>
> LoginContextProviderImpl#getLoginContext(...) extracts the most recent subject from the AccessControlContext and then uses it for either a PreAuthContext or a JaasLoginContext. This is wrong, because there is no reason to assume that such a subject has anything to do with Oak. It particularly hurts when it's readonly, because JAAS will then silently fail to add principals and credentials.
> We would need a way to identify pre-authenticated subjects and subjects that are not pre-authenticated should not be used to create a JaasLoginContext.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)