[jira] [Comment Edited] (OAK-4513) Detect and log references across stores

["Florin Iordache (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352792#comment-15352792 ] 

Florin Iordache edited comment on OAK-4513 at 6/28/16 11:04 AM:
----------------------------------------------------------------

hi [~chetanm], thanks for the feedback.
{quote}
This needs to be an OSGi component. Further the validator provides should only be registered if there are more than 1 mount i.e. ensure that it does not get activated for normal setups so as to minimize any potential overhead
Would need test coverage for the implementation
{quote}
Agreed, I'll work on it and come back with an updated patch.

{quote}
As for IdentifierManager - Would need to think on that as the query it fires would need to be run against indexes stored both in private and shared repo. So you cannot just construct it from default PropertyIndexProvider. Having a test would confirm the theory
{quote}
A query is the easiest way to find references based on a given uuid, and the {{IdentifierManager}} was implemented for this purpose. Do we already have some any IndexProvider implementation for the private repository that we could use in a real multiplexed scenario?
If using a query is not the desired way to go here, I'm open to any other suggestions on how we could validate the reference properties.




was (Author: florin.iordache):
hi [~chetanm], thanks for the feedback.
> This needs to be an OSGi component. Further the validator provides should only be registered if there are more than 1 mount i.e. ensure that it does not get activated for normal setups so as to minimize any potential overhead
> Would need test coverage for the implementation
Agreed, I'll work on it and come back with an updated patch.

>As for IdentifierManager - Would need to think on that as the query it fires would need to be run against indexes stored both in private and shared repo. So you cannot just construct it from default PropertyIndexProvider. Having a test would confirm the theory
A query is the easiest way to find references based on a given uuid, and the {{IdentifierManager}} was implemented for this purpose. Do we already have some any IndexProvider implementation for the private repository that we could use in a real multiplexed scenario?
If using a query is not the desired way to go here, I'm open to any other suggestions on how we could validate the reference properties.



> Detect and log references across stores
> ---------------------------------------
>
>                 Key: OAK-4513
>                 URL: https://issues.apache.org/jira/browse/OAK-4513
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Florin Iordache
>         Attachments: OAK-4513-patch.diff
>
>
> References across different stores will not be allowed at runtime, we need a commit validator to detect and log such cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)