[jira] [Commented] (MBUILDCACHE-32) Do not print exception when probing buildInfo.xml in remote repo

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MBUILDCACHE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626160#comment-17626160 ] 

ASF GitHub Bot commented on MBUILDCACHE-32:
-------------------------------------------

AlexanderAshitkin opened a new pull request, #33:
URL: https://github.com/apache/maven-build-cache-extension/pull/33

   … remote repo
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Do not print exception when probing buildInfo.xml in remote repo
> ----------------------------------------------------------------
>
>                 Key: MBUILDCACHE-32
>                 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-32
>             Project: Maven Build Cache Extension
>          Issue Type: Bug
>            Reporter: Alexander Ashitkin
>            Priority: Major
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When cache engine tries to discover existing cache by checksum, it sends get request. 
> This request is not expected to always return 200, because cache is not guaranteed to exist.
> It's a normal situation and exception should not be printed in such case:
> {code:java}
> org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at https://my-cache/.../buildinfo.xml, status: 404 Not Found
>     at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData (AbstractHttpClientWagon.java:1191)
>     at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData (AbstractHttpClientWagon.java:1140)
>     at org.apache.maven.wagon.StreamWagon.getInputStream (StreamWagon.java:126)
>     at org.apache.maven.wagon.StreamWagon.getIfNewerToStream (StreamWagon.java:226)
>     at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
>     at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run (WagonTransporter.java:533)
>     at org.eclipse.aether.transport.wagon.WagonTransporter.execute (WagonTransporter.java:425)
>     at org.eclipse.aether.transport.wagon.WagonTransporter.get (WagonTransporter.java:400)
>     at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent (RemoteCacheRepositoryImpl.java:165)
>     at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild (RemoteCacheRepositoryImpl.java:114)
>     at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild (LocalCacheRepositoryImpl.java:183)
>     at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild (CacheControllerImpl.java:212)
>     at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild (CacheControllerImpl.java:179)
>     at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute (BuildCacheMojosExecutionStrategy.java:114)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:179)
>  {code}
> {{Need to create method similar to RemoteCacheRepositoryImpl#getResourceContent, but }}{{getResourceContentQuiet and use it when probing buildinfo.xml. the method should not log exceptions}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)