You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org> on 2008/05/31 11:47:52 UTC
[jira] Created: (CAY-1060) CM: Allow multiple item selections
CM: Allow multiple item selections
----------------------------------
Key: CAY-1060
URL: https://issues.apache.org/cayenne/browse/CAY-1060
Project: Cayenne
Issue Type: Improvement
Components: CayenneModeler GUI
Affects Versions: 3.0
Reporter: Andrey Razumovsky
Assignee: Andrus Adamchik
Allow multiple item selections on the left-hand project tree and right-hand attribute panels. Common operations (like "delete") should work on multiple objects.
This is GSoC 2008 task
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1060) CM: Allow multiple item selections
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Razumovsky updated CAY-1060:
-----------------------------------
Attachment: patch-CAY-1060-2.txt
That's not that hard, however it seems to be Swing's original behavior in case of one-click editor activating, so custom CellEditor is required. Done in patch #2
> CM: Allow multiple item selections
> ----------------------------------
>
> Key: CAY-1060
> URL: https://issues.apache.org/cayenne/browse/CAY-1060
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrey Razumovsky
> Assignee: Kevin Menard
> Attachments: patch-CAY-1060-2.txt, patch-CAY-1060.txt
>
>
> Allow multiple item selections on the left-hand project tree and right-hand attribute panels. Common operations (like "delete") should work on multiple objects.
> This is GSoC 2008 task
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1060) CM: Allow multiple item selections
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Razumovsky updated CAY-1060:
-----------------------------------
Attachment: patch-CAY-1060.txt
Multiple selection is now allowed for left tree (any set of objects) and for Attributes, Relationships, Callbacks and Parameters tables.
> CM: Allow multiple item selections
> ----------------------------------
>
> Key: CAY-1060
> URL: https://issues.apache.org/cayenne/browse/CAY-1060
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrey Razumovsky
> Assignee: Kevin Menard
> Attachments: patch-CAY-1060.txt
>
>
> Allow multiple item selections on the left-hand project tree and right-hand attribute panels. Common operations (like "delete") should work on multiple objects.
> This is GSoC 2008 task
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1060) CM: Allow multiple item selections
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Razumovsky updated CAY-1060:
-----------------------------------
Attachment: fix-1060.txt
Previously applied patch breaks 'Search' functionality and also causes mess in event queue that can make ObjEntity views overlap each other. Also ObjEntity view often jumps to 'Attributes' or 'Relationship' tab. Patch 'fix-1060' solves those problems
> CM: Allow multiple item selections
> ----------------------------------
>
> Key: CAY-1060
> URL: https://issues.apache.org/cayenne/browse/CAY-1060
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrey Razumovsky
> Assignee: Kevin Menard
> Attachments: fix-1060.txt, patch-CAY-1060-2.txt, patch-CAY-1060-3.txt, patch-CAY-1060.txt
>
>
> Allow multiple item selections on the left-hand project tree and right-hand attribute panels. Common operations (like "delete") should work on multiple objects.
> This is GSoC 2008 task
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAY-1060) CM: Allow multiple item selections
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Menard reassigned CAY-1060:
---------------------------------
Assignee: Kevin Menard (was: Andrus Adamchik)
> CM: Allow multiple item selections
> ----------------------------------
>
> Key: CAY-1060
> URL: https://issues.apache.org/cayenne/browse/CAY-1060
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrey Razumovsky
> Assignee: Kevin Menard
>
> Allow multiple item selections on the left-hand project tree and right-hand attribute panels. Common operations (like "delete") should work on multiple objects.
> This is GSoC 2008 task
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1060) CM: Allow multiple item selections
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Razumovsky updated CAY-1060:
-----------------------------------
Attachment: patch-CAY-1060-3.txt
My apologies. Stupid error, and somehow i missed to test that. One line changed in patch-CAY-1060-3
> CM: Allow multiple item selections
> ----------------------------------
>
> Key: CAY-1060
> URL: https://issues.apache.org/cayenne/browse/CAY-1060
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrey Razumovsky
> Assignee: Kevin Menard
> Attachments: patch-CAY-1060-2.txt, patch-CAY-1060-3.txt, patch-CAY-1060.txt
>
>
> Allow multiple item selections on the left-hand project tree and right-hand attribute panels. Common operations (like "delete") should work on multiple objects.
> This is GSoC 2008 task
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-1060) CM: Allow multiple item selections
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12939#action_12939 ]
Kevin Menard commented on CAY-1060:
-----------------------------------
I haven't had an opportunity to review the code itself, but the feature seems implemented as designed. One complaint I have is that multiple selection in the editors (e.g., ObjAttribute) act a little odd with multiple selection. Rather than treat each selected item as a selection, it treats the last click one as an edit operation, which is a little jarring. I don't know how much effort it would take to fix that, but if you could look into it, that'd be aprreciated.
> CM: Allow multiple item selections
> ----------------------------------
>
> Key: CAY-1060
> URL: https://issues.apache.org/cayenne/browse/CAY-1060
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrey Razumovsky
> Assignee: Kevin Menard
> Attachments: patch-CAY-1060.txt
>
>
> Allow multiple item selections on the left-hand project tree and right-hand attribute panels. Common operations (like "delete") should work on multiple objects.
> This is GSoC 2008 task
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CAY-1060) CM: Allow multiple item selections
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Menard closed CAY-1060.
-----------------------------
Resolution: Fixed
I've applied patch #2, with minor cleanups. Please don't use underscores in variables names -- use camel case. Please place spaces between control keywords and opening parens (i.e., "if (" rather than "if(" ) and please always enclose control statement bodies in braces.
Otherwise, the code looked quite good. It took me a while to understand some of it due to the overall lack of comments. Since the original code wasn't commented very well, it's hard to fault the submitter, but comments should be part of any patch submission.
> CM: Allow multiple item selections
> ----------------------------------
>
> Key: CAY-1060
> URL: https://issues.apache.org/cayenne/browse/CAY-1060
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrey Razumovsky
> Assignee: Kevin Menard
> Attachments: patch-CAY-1060-2.txt, patch-CAY-1060.txt
>
>
> Allow multiple item selections on the left-hand project tree and right-hand attribute panels. Common operations (like "delete") should work on multiple objects.
> This is GSoC 2008 task
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CAY-1060) CM: Allow multiple item selections
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Menard closed CAY-1060.
-----------------------------
Resolution: Fixed
The latest patch does fix the bug I saw. So, closing the issue for good hopefully.
> CM: Allow multiple item selections
> ----------------------------------
>
> Key: CAY-1060
> URL: https://issues.apache.org/cayenne/browse/CAY-1060
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrey Razumovsky
> Assignee: Kevin Menard
> Attachments: patch-CAY-1060-2.txt, patch-CAY-1060-3.txt, patch-CAY-1060.txt
>
>
> Allow multiple item selections on the left-hand project tree and right-hand attribute panels. Common operations (like "delete") should work on multiple objects.
> This is GSoC 2008 task
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CAY-1060) CM: Allow multiple item selections
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Menard reopened CAY-1060:
-------------------------------
Shortly after committing I discovered that there's no way to enable the info button on an ObjRelationship. That needs to be addressed.
> CM: Allow multiple item selections
> ----------------------------------
>
> Key: CAY-1060
> URL: https://issues.apache.org/cayenne/browse/CAY-1060
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrey Razumovsky
> Assignee: Kevin Menard
> Attachments: patch-CAY-1060-2.txt, patch-CAY-1060.txt
>
>
> Allow multiple item selections on the left-hand project tree and right-hand attribute panels. Common operations (like "delete") should work on multiple objects.
> This is GSoC 2008 task
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.