You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramachandran Krishnan <ra...@gmail.com> on 2023/02/03 11:40:40 UTC
Review Request 74291: RANGER-4055:Compulsory field firstName can be passed empty or null in the payload while creating user through API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74291/
-----------------------------------------------------------
Review request for ranger, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Bugs: RANGER-4055
https://issues.apache.org/jira/browse/RANGER-4055
Repository: ranger
Description
-------
While creating a user from UI its firstName is a compulsory field but while creating it through making POST request on /xuser/secure/users its not a compulsory parameter.
Steps to reproduce:
Make a post request on /xuser/secure/users endpoint with following payload:
{ "name":"temp_user_abc_12345", "firstName":null, "lastName": "user1", "loginId": "user1", "emailAddress" : null, "description" : "user1 desc", "password" : "user1Pass@123", "groupIdList":[1], "groupNameList":["public"], "status":1, "isVisible":1, "userRoleList": [ "ROLE_USER" ], "userSource": 0 }
Response:
{ "id": 323, "createDate": "2023-01-17T06:49:12Z", "updateDate": "2023-01-17T06:49:12Z", "owner": "Admin", "updatedBy": "Admin", "name": "temp_user_abc_12345", "lastName": "user1", "password": "*****", "description": "user1 desc", "groupIdList": [ 1 ], "groupNameList": [ "public" ], "status": 1, "isVisible": 1, "userSource": 0, "userRoleList": [ "ROLE_USER" ] }
With firstName as null also the user is creating successfully.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 0a03da567
security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 871857bbf
Diff: https://reviews.apache.org/r/74291/diff/1/
Testing
-------
Thanks,
Ramachandran Krishnan
Re: Review Request 74291: RANGER-4055:Compulsory field firstName can be passed empty or null in the payload while creating user through API
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74291/#review225154
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 3, 2023, 11:40 a.m., Ramachandran Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74291/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2023, 11:40 a.m.)
>
>
> Review request for ranger, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4055
> https://issues.apache.org/jira/browse/RANGER-4055
>
>
> Repository: ranger
>
>
> Description
> -------
>
> While creating a user from UI its firstName is a compulsory field but while creating it through making POST request on /xuser/secure/users its not a compulsory parameter.
>
>
>
> Steps to reproduce:
>
> Make a post request on /xuser/secure/users endpoint with following payload:
>
> { "name":"temp_user_abc_12345", "firstName":null, "lastName": "user1", "loginId": "user1", "emailAddress" : null, "description" : "user1 desc", "password" : "user1Pass@123", "groupIdList":[1], "groupNameList":["public"], "status":1, "isVisible":1, "userRoleList": [ "ROLE_USER" ], "userSource": 0 }
> Response:
>
> { "id": 323, "createDate": "2023-01-17T06:49:12Z", "updateDate": "2023-01-17T06:49:12Z", "owner": "Admin", "updatedBy": "Admin", "name": "temp_user_abc_12345", "lastName": "user1", "password": "*****", "description": "user1 desc", "groupIdList": [ 1 ], "groupNameList": [ "public" ], "status": 1, "isVisible": 1, "userSource": 0, "userRoleList": [ "ROLE_USER" ] }
>
> With firstName as null also the user is creating successfully.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 0a03da567
> security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 871857bbf
>
>
> Diff: https://reviews.apache.org/r/74291/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ramachandran Krishnan
>
>