You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Velmurugan Periasamy <vp...@hortonworks.com> on 2016/02/14 23:06:52 UTC
Re: Review Request 43376: Ranger-840: ranger-admin and
ranger-usersync does not honour the SSL truststore property
> On Feb. 12, 2016, 11:40 p.m., Velmurugan Periasamy wrote:
> > security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java, line 73
> > <https://reviews.apache.org/r/43376/diff/1/?file=1238812#file1238812line73>
> >
> > Consider getting the password from credential store?
Password for trust store files are still handled the same way. Needs to be addressed later.
- Velmurugan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43376/#review119108
-----------------------------------------------------------
On Feb. 9, 2016, 9:42 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43376/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 9:42 p.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: Ranger-840
> https://issues.apache.org/jira/browse/Ranger-840
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added support for ranger usersync and ranger admin to use configured custom truststore for LDAPS connectivity.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 5229fe7
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/CustomSSLSocketFactory.java PRE-CREATION
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 99403d7
>
> Diff: https://reviews.apache.org/r/43376/diff/
>
>
> Testing
> -------
>
> 1. Tested usersync & ranger admin with and without custom truststore for LDAPS connectivity.
> 2. Tested with default truststore for regression cases
> 3. Ran some negative tests like invalid rootca, empty truststore, etc... for usersync as well as ranger admin.
> 4. For ranger admin, added the truststore properties as part of custom properties for validation.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>