You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/12/13 19:53:28 UTC
[I] Transition zoostore deferral tracking to use System.nanoTime [accumulo]
keith-turner opened a new issue, #4068:
URL: https://github.com/apache/accumulo/issues/4068
**Describe the bug**
When a FATE operation is unreserved with a deferral time, the code uses System.currentTimeMillis() to determine when the operation should run again. In the case where wall time changes on the machine this could cause this deferral tracking to be incorrect, in the worse case causing something to not run for long periods of time.
**Expected behavior**
If would be best if the deferral time tracking in ZooStore used System.nanoTime instead of System.currentTimeMillis as this avoids problems with wall time changing. We could also modify the method signature of
```java
public void unreserve(long tid, long deferTime)
```
to
```java
public void unreserve(long tid, long deferTime, TimeUnit deferTimeUnuit)
```
All the code that calls this method would still pass milliseconds, so making the time unit explicit would make the code less confusing if the ZooStore impl uses nano seconds and its routinely passed milliseconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Transition zoostore deferral tracking to use System.nanoTime [accumulo]
Posted by "kevinrr888 (via GitHub)" <gi...@apache.org>.
kevinrr888 commented on issue #4068:
URL: https://github.com/apache/accumulo/issues/4068#issuecomment-1871477219
I would like to work on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Transition zoostore deferral tracking to use System.nanoTime [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #4068:
URL: https://github.com/apache/accumulo/issues/4068#issuecomment-1854618190
This is one place where the deferral happens in zoostore
https://github.com/apache/accumulo/blob/4d38127e5a3f10e404e90323c49cf146f4c70007/core/src/main/java/org/apache/accumulo/core/fate/ZooStore.java#L289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Transition zoostore deferral tracking to use System.nanoTime [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner closed issue #4068: Transition zoostore deferral tracking to use System.nanoTime
URL: https://github.com/apache/accumulo/issues/4068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Transition zoostore deferral tracking to use System.nanoTime [accumulo]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on issue #4068:
URL: https://github.com/apache/accumulo/issues/4068#issuecomment-1867905255
The AccumuloStore will also need to be updated that was added in #4049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Transition zoostore deferral tracking to use System.nanoTime [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #4068:
URL: https://github.com/apache/accumulo/issues/4068#issuecomment-1878993914
Done in #4126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Transition zoostore deferral tracking to use System.nanoTime [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #4068:
URL: https://github.com/apache/accumulo/issues/4068#issuecomment-1854615044
Not sure of the versions where this should be fixed. It could be fixed in 2.1 and would be a nice fix to have there as long as it does not introduce new bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org