[jira] [Commented] (SOLR-7158) ZkConfigManager filesystem fixes for Windows

["Alan Woodward (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336356#comment-14336356 ] 

Alan Woodward commented on SOLR-7158:
-------------------------------------

Thanks Ishan!

Is the second Files.createDirectories() actually necessary?  It's already called at the top of downloadFromZk

> ZkConfigManager filesystem fixes for Windows
> --------------------------------------------
>
>                 Key: SOLR-7158
>                 URL: https://issues.apache.org/jira/browse/SOLR-7158
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Ishan Chattopadhyaya
>            Assignee: Alan Woodward
>         Attachments: SOLR-7158.patch
>
>
> There were a couple of issues with ZkConfigManager:
> * Directories are not created recursively in Windows with nio.Files.write(). Need to pre-create the directory structure while downloading config.
> * The separator for zk nodes is '/'. However, on Windows, while uploading the relative files nested within a directory (e.g. velocity\hit-plain.vm) contain '\'. This, apart from causing an inconsistency as compared to zk on posix systems, messed up the ZkCLITest on Windows where count of files in zk and files in the filesystem was compared.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org