[GitHub] [pinot] 61yao commented on a diff in pull request #9775: [multistage] Add join operator unit test and fix the bug when left join table is empty

[GitBox <gi...@apache.org>]

61yao commented on code in PR #9775:
URL: https://github.com/apache/pinot/pull/9775#discussion_r1019914809


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/QueryTestSet.java:
##########
@@ -26,6 +26,11 @@ public class QueryTestSet {
   @DataProvider(name = "testSql")
   public Object[][] provideTestSql() {
     return new Object[][]{
+        // Failed left join. Not sure what's the expectation here.
+        // new Object[]{"SELECT a.col1 FROM a LEFT JOIN b ON (a.col1 = 'foo')"},

Review Comment:
   Removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org