[GitHub] [camel] gnodet commented on a change in pull request #4089: Removes unreachable branch on camel-aws-s3 client implementations

[GitBox <gi...@apache.org>]

gnodet commented on a change in pull request #4089:
URL: https://github.com/apache/camel/pull/4089#discussion_r471496007



##########
File path: components/camel-aws-s3/src/main/java/org/apache/camel/component/aws/s3/client/impl/S3ClientIAMOptimizedImpl.java
##########
@@ -74,12 +74,14 @@ public AmazonS3 getS3Client() {
 
         if (!configuration.isUseEncryption()) {
             clientBuilder = AmazonS3ClientBuilder.standard().withCredentials(new InstanceProfileCredentialsProvider(false));
-        } else if (configuration.isUseEncryption()) {
+
+            if (configuration.hasProxyConfiguration()) {
+                clientBuilder = clientBuilder.withClientConfiguration(clientConfiguration);
+            }

Review comment:
       This seems a slightly different issue.  Should this be in a separate commit ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org