You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ashb (via GitHub)" <gi...@apache.org> on 2025/02/06 13:59:56 UTC

[PR] Remove `ds`/`ts` etc from Template/run context when no logical date is defined [airflow]

ashb opened a new pull request, #46522:
URL: https://github.com/apache/airflow/pull/46522

   This is part of the AIP-83 ammendments.
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove `ds`/`ts` etc from Template/run context when no logical date is defined [airflow]

Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb merged PR #46522:
URL: https://github.com/apache/airflow/pull/46522


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove `ds`/`ts` etc from Template/run context when no logical date is defined [airflow]

Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #46522:
URL: https://github.com/apache/airflow/pull/46522#issuecomment-2639910624

   This also fixes #46521 in the way going forward. If this doesn't pass tests lets go for that version though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove `ds`/`ts` etc from Template/run context when no logical date is defined [airflow]

Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #46522:
URL: https://github.com/apache/airflow/pull/46522#discussion_r1944811828


##########
airflow/models/dagrun.py:
##########
@@ -793,6 +793,8 @@ def get_previous_dagrun(
         :param session: SQLAlchemy ORM Session
         :param state: the dag run state
         """
+        if dag_run.logical_date is None:

Review Comment:
   It wasn't in https://cwiki.apache.org/confluence/display/AIRFLOW/Option+2+clarification+doc+WIP -- but I think the whole point is that manually triggered dags dont have any concept of previous, as that is tied to having a logical date.
   
   Without this it errored as we tried to do `TaskInstance.logical_date < None` (where `dag_run.logical_date == None`) so I think this is theright thing to do



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove `ds`/`ts` etc from Template/run context when no logical date is defined [airflow]

Posted by "sunank200 (via GitHub)" <gi...@apache.org>.
sunank200 commented on code in PR #46522:
URL: https://github.com/apache/airflow/pull/46522#discussion_r1944803823


##########
airflow/models/dagrun.py:
##########
@@ -793,6 +793,8 @@ def get_previous_dagrun(
         :param session: SQLAlchemy ORM Session
         :param state: the dag run state
         """
+        if dag_run.logical_date is None:

Review Comment:
   But is this correct for all manually triggered DAG runs when logical_date is None?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org