[GitHub] [linkis] rarexixi commented on a diff in pull request #4301: [feat]Support spark3.3+ and spark2.2- compile

["rarexixi (via GitHub)" <gi...@apache.org>]

rarexixi commented on code in PR #4301:
URL: https://github.com/apache/linkis/pull/4301#discussion_r1125926436


##########
linkis-engineconn-plugins/spark/src/main/scala/org/apache/linkis/engineplugin/spark/datacalc/sink/JdbcSink.scala:
##########
@@ -58,7 +60,7 @@ class JdbcSink extends DataCalcSink[JdbcSinkConfig] with Logging {
         .repartition(1)
         .foreachPartition((_: Iterator[Row]) => {
           val jdbcOptions = new JDBCOptions(options)
-          val conn: Connection = JdbcUtils.createConnectionFactory(jdbcOptions)()
+          val conn: Connection = createConnectionFactory(jdbcOptions)()

Review Comment:
   Replace with `DriverManager.getConnection(config.getUrl, config.getUser, config.getPassword)` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org