You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by pa...@apache.org on 2007/10/26 14:40:27 UTC
svn commit: r588628 -
/directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
Author: pamarcelot
Date: Fri Oct 26 05:40:26 2007
New Revision: 588628
URL: http://svn.apache.org/viewvc?rev=588628&view=rev
Log:
Fixed a NPE which caused the SchemaBrowser to not be opened correctly.
Modified:
directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
Modified: directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java?rev=588628&r1=588627&r2=588628&view=diff
==============================================================================
--- directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java (original)
+++ directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java Fri Oct 26 05:40:26 2007
@@ -92,7 +92,7 @@
comboViewer = new ComboViewer( parent, SWT.DROP_DOWN | SWT.READ_ONLY );
comboViewer.setLabelProvider( new ConnectionLabelProvider() );
comboViewer.setContentProvider( new ConnectionContentProvider() );
- comboViewer.setInput( ConnectionCorePlugin.getDefault().getConnectionManager() );
+ comboViewer.setInput( ConnectionCorePlugin.getDefault().getConnectionFolderManager() );
comboViewer.addSelectionChangedListener( new ISelectionChangedListener()
{
public void selectionChanged( SelectionChangedEvent event )
Re: svn commit: r588628 - /directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
Stefan (S.), could you please verify I'm not doing somtehing wrong here ?
Thanks,
P-A
On 10/26/07, pamarcelot@apache.org <pa...@apache.org> wrote:
>
> Author: pamarcelot
> Date: Fri Oct 26 05:40:26 2007
> New Revision: 588628
>
> URL: http://svn.apache.org/viewvc?rev=588628&view=rev
> Log:
> Fixed a NPE which caused the SchemaBrowser to not be opened correctly.
>
> Modified:
>
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
>
> Modified:
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> URL:
> http://svn.apache.org/viewvc/directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java?rev=588628&r1=588627&r2=588628&view=diff
>
> ==============================================================================
> ---
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> (original)
> +++
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> Fri Oct 26 05:40:26 2007
> @@ -92,7 +92,7 @@
> comboViewer = new ComboViewer( parent, SWT.DROP_DOWN |
> SWT.READ_ONLY );
> comboViewer.setLabelProvider( new ConnectionLabelProvider() );
> comboViewer.setContentProvider( new ConnectionContentProvider()
> );
> - comboViewer.setInput( ConnectionCorePlugin.getDefault().getConnectionManager()
> );
> + comboViewer.setInput( ConnectionCorePlugin.getDefault().getConnectionFolderManager()
> );
> comboViewer.addSelectionChangedListener( new
> ISelectionChangedListener()
> {
> public void selectionChanged( SelectionChangedEvent event )
>
>
>
Re: svn commit: r588628 - /directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
Posted by Stefan Seelmann <se...@apache.org>.
Hi Pierre-Arnaud,
this is just perfect, many thanks.
Reagrds,
Stefan S.
Pierre-Arnaud Marcelot schrieb:
> Hi Stefan S.,
>
> I just rollback this commit (see rev. 589605).
>
> I modified the connection selection by using the
> BrowserConnectionWidget, as you advised me on IM, at commits 589607 &
> 589614.
>
> Regards,
> P-A
>
>
> On 10/26/07, *Pierre-Arnaud Marcelot* <pa@marcelot.net
> <ma...@marcelot.net>> wrote:
>
> Stefan (S.), could you please verify I'm not doing somtehing wrong
> here ?
>
> Thanks,
> P-A
>
> On 10/26/07, * pamarcelot@apache.org <ma...@apache.org>*
> <pamarcelot@apache.org <ma...@apache.org>> wrote:
>
> Author: pamarcelot
> Date: Fri Oct 26 05:40:26 2007
> New Revision: 588628
>
> URL: http://svn.apache.org/viewvc?rev=588628&view=rev
> <http://svn.apache.org/viewvc?rev=588628&view=rev>
> Log:
> Fixed a NPE which caused the SchemaBrowser to not be opened
> correctly.
>
> Modified:
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
>
> Modified:
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
>
> URL:
> http://svn.apache.org/viewvc/directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java?rev=588628&r1=588627&r2=588628&view=diff
> <http://svn.apache.org/viewvc/directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java?rev=588628&r1=588627&r2=588628&view=diff>
> ==============================================================================
> ---
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> (original)
> +++
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> Fri Oct 26 05:40:26 2007
> @@ -92,7 +92,7 @@
> comboViewer = new ComboViewer( parent, SWT.DROP_DOWN |
> SWT.READ_ONLY );
> comboViewer.setLabelProvider( new
> ConnectionLabelProvider() );
> comboViewer.setContentProvider( new
> ConnectionContentProvider() );
> - comboViewer.setInput(
> ConnectionCorePlugin.getDefault().getConnectionManager() );
> + comboViewer.setInput(
> ConnectionCorePlugin.getDefault().getConnectionFolderManager() );
> comboViewer.addSelectionChangedListener( new
> ISelectionChangedListener()
> {
> public void selectionChanged( SelectionChangedEvent
> event )
>
>
>
>
Re: svn commit: r588628 - /directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
Hi Stefan S.,
I just rollback this commit (see rev. 589605).
I modified the connection selection by using the BrowserConnectionWidget, as
you advised me on IM, at commits 589607 & 589614.
Regards,
P-A
On 10/26/07, Pierre-Arnaud Marcelot <pa...@marcelot.net> wrote:
>
> Stefan (S.), could you please verify I'm not doing somtehing wrong here ?
>
> Thanks,
> P-A
>
> On 10/26/07, pamarcelot@apache.org <pa...@apache.org> wrote:
> >
> > Author: pamarcelot
> > Date: Fri Oct 26 05:40:26 2007
> > New Revision: 588628
> >
> > URL: http://svn.apache.org/viewvc?rev=588628&view=rev
> > Log:
> > Fixed a NPE which caused the SchemaBrowser to not be opened correctly.
> >
> > Modified:
> >
> > directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> >
> > Modified:
> > directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> >
> > URL: http://svn.apache.org/viewvc/directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java?rev=588628&r1=588627&r2=588628&view=diff
> >
> >
> > ==============================================================================
> > ---
> > directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> > (original)
> > +++
> > directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> > Fri Oct 26 05:40:26 2007
> > @@ -92,7 +92,7 @@
> > comboViewer = new ComboViewer( parent, SWT.DROP_DOWN |
> > SWT.READ_ONLY );
> > comboViewer.setLabelProvider( new ConnectionLabelProvider() );
> > comboViewer.setContentProvider( new ConnectionContentProvider()
> > );
> > - comboViewer.setInput( ConnectionCorePlugin.getDefault().getConnectionManager()
> > );
> > + comboViewer.setInput( ConnectionCorePlugin.getDefault().getConnectionFolderManager()
> > );
> > comboViewer.addSelectionChangedListener( new
> > ISelectionChangedListener()
> > {
> > public void selectionChanged( SelectionChangedEvent event )
> >
> >
> >
>
Re: svn commit: r588628 - /directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
Stefan (S.), could you please verify I'm not doing somtehing wrong here ?
Thanks,
P-A
On 10/26/07, pamarcelot@apache.org <pa...@apache.org> wrote:
>
> Author: pamarcelot
> Date: Fri Oct 26 05:40:26 2007
> New Revision: 588628
>
> URL: http://svn.apache.org/viewvc?rev=588628&view=rev
> Log:
> Fixed a NPE which caused the SchemaBrowser to not be opened correctly.
>
> Modified:
>
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
>
> Modified:
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> URL:
> http://svn.apache.org/viewvc/directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java?rev=588628&r1=588627&r2=588628&view=diff
>
> ==============================================================================
> ---
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> (original)
> +++
> directory/studio/trunk/studio-ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/schemabrowser/ConnectionComboContributionItem.java
> Fri Oct 26 05:40:26 2007
> @@ -92,7 +92,7 @@
> comboViewer = new ComboViewer( parent, SWT.DROP_DOWN |
> SWT.READ_ONLY );
> comboViewer.setLabelProvider( new ConnectionLabelProvider() );
> comboViewer.setContentProvider( new ConnectionContentProvider()
> );
> - comboViewer.setInput( ConnectionCorePlugin.getDefault().getConnectionManager()
> );
> + comboViewer.setInput( ConnectionCorePlugin.getDefault().getConnectionFolderManager()
> );
> comboViewer.addSelectionChangedListener( new
> ISelectionChangedListener()
> {
> public void selectionChanged( SelectionChangedEvent event )
>
>
>