[GitHub] [spark] zsxwing commented on a diff in pull request #38623: [WIP][SPARK-41072][SQL][SS] Add the error class `STREAM_FAILED`

[GitBox <gi...@apache.org>]

zsxwing commented on code in PR #38623:
URL: https://github.com/apache/spark/pull/38623#discussion_r1020491006


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala:
##########
@@ -321,7 +321,10 @@ abstract class StreamExecution(
         // to `new IOException(ie.toString())` before Hadoop 2.8.
         updateStatusMessage("Stopped")
       case t: Throwable =>
-        val e = QueryExecution.toInternalError(msg = s"Execution of the stream $name failed.", t)
+        val e = t match {
+          case _: SparkThrowable => t
+          case _ => QueryExecutionErrors.streamFailed(prettyIdString, t)

Review Comment:
   We will wrap this below as a `StreamingQueryException`. Do we really need to wrap it twice?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org