You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/04 04:21:07 UTC

[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4175: docs: fix broken links and ids in plugins

KishaniKandasamy commented on a change in pull request #4175:
URL: https://github.com/apache/apisix/pull/4175#discussion_r625500422



##########
File path: docs/en/latest/plugins/authz-keycloak.md
##########
@@ -42,9 +42,9 @@ For more information on Keycloak, refer to [Keycloak Authorization Docs](https:/
 
 | Name                           | Type          | Requirement | Default                                       | Valid                                                              | Description                                                                                                                                                 |
 | ------------------------------ | ------------- | ----------- | --------------------------------------------- | ------------------------------------------------------------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| discovery                      | string        | optional    |                                               | https://host.domain/auth/realms/foo/.well-known/uma2-configuration | URL to discovery document for Keycloak Authorization Services.                                                                                              |
-| token_endpoint                 | string        | optional    |                                               | https://host.domain/auth/realms/foo/protocol/openid-connect/token  | A OAuth2-compliant Token Endpoint that supports the `urn:ietf:params:oauth:grant-type:uma-ticket` grant type. Overrides value from discovery, if given.     |
-| resource_registration_endpoint | string        | optional    |                                               | https://host.domain/auth/realms/foo/authz/protection/resource_set  | A Keycloak Protection API-compliant resource registration endpoint. Overrides value from discovery, if given.                                               |
+| discovery                      | string        | optional    |                                               | `https://host.domain/auth/realms/foo/.well-known/uma2-configuration` | URL to discovery document for Keycloak Authorization Services.                                                                                              |

Review comment:
       I thought they are just **valid url format** and it seems they don't direct to anywhere.
   
   ![2](https://user-images.githubusercontent.com/53715187/116960456-0c983f00-acbe-11eb-9928-24af16ae6f53.JPG)
   ![1](https://user-images.githubusercontent.com/53715187/116960447-073af480-acbe-11eb-9001-a413888aeb15.JPG)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org