You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Paul Elschot (JIRA)" <ji...@apache.org> on 2008/09/08 14:46:44 UTC
[jira] Created: (LUCENE-1379) SpanScorer fails when sloppyFreq()
returns 0
SpanScorer fails when sloppyFreq() returns 0
--------------------------------------------
Key: LUCENE-1379
URL: https://issues.apache.org/jira/browse/LUCENE-1379
Project: Lucene - Java
Issue Type: Bug
Components: Search
Reporter: Paul Elschot
Priority: Minor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1379) SpanScorer fails when sloppyFreq()
returns 0
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1379:
---------------------------------------
Description: I think we should fix this for 2.4 (now back to 10)?
Fix Version/s: 2.4
> SpanScorer fails when sloppyFreq() returns 0
> --------------------------------------------
>
> Key: LUCENE-1379
> URL: https://issues.apache.org/jira/browse/LUCENE-1379
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Fix For: 2.4
>
> Attachments: LUCENE-1379.patch
>
>
> I think we should fix this for 2.4 (now back to 10)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1379) SpanScorer fails when sloppyFreq()
returns 0
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631264#action_12631264 ]
Paul Elschot commented on LUCENE-1379:
--------------------------------------
Since this is really a corner case, it does not really matter whether it gets into 2.4 or not.
> SpanScorer fails when sloppyFreq() returns 0
> --------------------------------------------
>
> Key: LUCENE-1379
> URL: https://issues.apache.org/jira/browse/LUCENE-1379
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Fix For: 2.4
>
> Attachments: LUCENE-1379-test.patch, LUCENE-1379.patch
>
>
> I think we should fix this for 2.4 (now back to 10)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1379) SpanScorer fails when sloppyFreq()
returns 0
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Elschot updated LUCENE-1379:
---------------------------------
Attachment: LUCENE-1379-test.patch
The bug occurs only for the last matching doc.
The attached LUCENE-1379-test.patch adds a test case for this, the test passes with the other LUCENE-1379.patch applied, and fails on trunk.
> SpanScorer fails when sloppyFreq() returns 0
> --------------------------------------------
>
> Key: LUCENE-1379
> URL: https://issues.apache.org/jira/browse/LUCENE-1379
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Fix For: 2.4
>
> Attachments: LUCENE-1379-test.patch, LUCENE-1379.patch
>
>
> I think we should fix this for 2.4 (now back to 10)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1379) SpanScorer fails when sloppyFreq()
returns 0
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Elschot updated LUCENE-1379:
---------------------------------
Attachment: LUCENE-1379.patch
The patch of 20080908 compiles, but it is untested because of other changes pending in my working copy.
> SpanScorer fails when sloppyFreq() returns 0
> --------------------------------------------
>
> Key: LUCENE-1379
> URL: https://issues.apache.org/jira/browse/LUCENE-1379
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: LUCENE-1379.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1379) SpanScorer fails when sloppyFreq()
returns 0
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631511#action_12631511 ]
Michael McCandless commented on LUCENE-1379:
--------------------------------------------
OK I now understand this patch -- checking freq != 0 (as the return value) is not a valid way to return the value for next() or skipTo(), because sloppyFreq could return 0, for the last doc in the in iteration.
I will commit shortly! Thanks Paul.
> SpanScorer fails when sloppyFreq() returns 0
> --------------------------------------------
>
> Key: LUCENE-1379
> URL: https://issues.apache.org/jira/browse/LUCENE-1379
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Fix For: 2.4
>
> Attachments: LUCENE-1379-test.patch, LUCENE-1379.patch
>
>
> I think we should fix this for 2.4 (now back to 10)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1379) SpanScorer fails when sloppyFreq()
returns 0
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630562#action_12630562 ]
Mark Miller commented on LUCENE-1379:
-------------------------------------
How does it fail Paul? I am trying to duplicate by returning 0 with a custom Similarity. This causes a score of 0 of course, but I don't see the failure. After applying your patch, I see the same behavior - a total score of a zero and no failure (that I can tell of course). Any hints about the problem?
> SpanScorer fails when sloppyFreq() returns 0
> --------------------------------------------
>
> Key: LUCENE-1379
> URL: https://issues.apache.org/jira/browse/LUCENE-1379
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Fix For: 2.4
>
> Attachments: LUCENE-1379.patch
>
>
> I think we should fix this for 2.4 (now back to 10)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1379) SpanScorer fails when sloppyFreq()
returns 0
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631513#action_12631513 ]
Paul Elschot commented on LUCENE-1379:
--------------------------------------
For this cornercase I thought a test case would be smaller than an explanation, but you just proved me wrong.
> SpanScorer fails when sloppyFreq() returns 0
> --------------------------------------------
>
> Key: LUCENE-1379
> URL: https://issues.apache.org/jira/browse/LUCENE-1379
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Fix For: 2.4
>
> Attachments: LUCENE-1379-test.patch, LUCENE-1379.patch
>
>
> I think we should fix this for 2.4 (now back to 10)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1379) SpanScorer fails when sloppyFreq()
returns 0
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1379.
----------------------------------------
Resolution: Fixed
Assignee: Michael McCandless
Sending src/java/org/apache/lucene/search/spans/SpanScorer.java
Sending src/test/org/apache/lucene/search/spans/TestSpans.java
Transmitting file data ..
Committed revision 696013.
Thanks Paul!
> SpanScorer fails when sloppyFreq() returns 0
> --------------------------------------------
>
> Key: LUCENE-1379
> URL: https://issues.apache.org/jira/browse/LUCENE-1379
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.4
>
> Attachments: LUCENE-1379-test.patch, LUCENE-1379.patch
>
>
> I think we should fix this for 2.4 (now back to 10)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org