[GitHub] [pulsar] mattisonchao commented on a diff in pull request #21193: [improve][broker] Avoid record inactiveproducers when deduplication is disable.

["mattisonchao (via GitHub)" <gi...@apache.org>]

mattisonchao commented on code in PR #21193:
URL: https://github.com/apache/pulsar/pull/21193#discussion_r1335317596


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/MessageDeduplication.java:
##########
@@ -493,6 +501,12 @@ public synchronized void purgeInactiveProducers() {
         long minimumActiveTimestamp = System.currentTimeMillis() - TimeUnit.MINUTES
                 .toMillis(pulsar.getConfiguration().getBrokerDeduplicationProducerInactivityTimeoutMinutes());
 
+        // if not enabled just clear all inactive producer record.
+        if (!isEnabled()) {

Review Comment:
   Why put the check here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org