You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rhtyd <gi...@git.apache.org> on 2016/09/29 09:44:07 UTC
[GitHub] cloudstack pull request #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 a...
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1696
[4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a guest OS
Adds Ubuntu 16.04 as a supported guest os. This allows users to select
the OS when creating a template etc.
SQL queries tested and adapted from https://issues.apache.org/jira/browse/CLOUDSTACK-9364
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack 4.9-ubuntuxenial-guestos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1696.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1696
----
commit d706ebc673f25f9ad84e7c266e0f6d4bf6f5a9a5
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-09-29T09:42:02Z
CLOUDSTACK-9364: Add Ubuntu 16.04 as a guest OS
Adds Ubuntu 16.04 as a supported guest os. This allows users to select
the OS when creating a template etc.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1696
<b>Trillian test result (tid-86)</b>
Environment: kvm-centos7 (x2), Advanced Networking
Total time taken: 24408 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1696-t86-kvm-centos7.zip
Test completed. 40 look ok, 13 have errors
Test | Result | Time (s)
--- | --- | ---
test_router_dhcphosts | `Failure` | 57.484
test_isolate_network_password_server | `Failure` | 55.984
test_04_rvpc_privategw_static_routes | `Failure` | 142.820
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 77.324
test_02_vpc_privategw_static_routes | `Failure` | 82.466
test_02_redundant_VPC_default_routes | `Failure` | 213.885
test_02_VPC_default_routes | `Failure` | 141.298
test_01_vpc_privategw_acl | `Failure` | 47.069
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 151.486
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 178.388
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 744.810
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 735.473
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 731.430
test_network_acl | `Error` | 0.132
test_extendPhysicalNetworkVlan | `Error` | 0.036
test_deploy_vm_from_iso | `Error` | 241.895
test_02_routervm_iptables_policies | `Error` | 779.925
test_01_single_VPC_iptables_policies | `Error` | 865.309
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.000
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.000
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 102.923
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.000
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_router_dns_guestipquery | Success | 80.821
test_router_dns_externalipquery | Success | 0.074
test_rolepermission_lifecycle_update | Success | 7.047
test_rolepermission_lifecycle_list | Success | 6.887
test_rolepermission_lifecycle_delete | Success | 6.862
test_rolepermission_lifecycle_create | Success | 6.786
test_rolepermission_lifecycle_concurrent_updates | Success | 6.894
test_role_lifecycle_update_role_inuse | Success | 6.806
test_role_lifecycle_update | Success | 11.861
test_role_lifecycle_list | Success | 6.771
test_role_lifecycle_delete | Success | 6.813
test_role_lifecycle_create | Success | 6.818
test_role_inuse_deletion | Success | 6.948
test_role_account_acls_multiple_mgmt_servers | Success | 9.096
test_role_account_acls | Success | 9.342
test_releaseIP | Success | 268.940
test_reboot_router | Success | 384.263
test_public_ip_user_account | Success | 10.261
test_public_ip_admin_account | Success | 40.308
test_oobm_zchange_password | Success | 20.618
test_oobm_multiple_mgmt_server_ownership | Success | 14.577
test_oobm_issue_power_status | Success | 10.563
test_oobm_issue_power_soft | Success | 15.587
test_oobm_issue_power_reset | Success | 15.588
test_oobm_issue_power_on | Success | 15.604
test_oobm_issue_power_off | Success | 15.607
test_oobm_issue_power_cycle | Success | 15.671
test_oobm_enabledisable_across_clusterzones | Success | 48.424
test_oobm_enable_feature_valid | Success | 5.176
test_oobm_enable_feature_invalid | Success | 0.109
test_oobm_disable_feature_valid | Success | 5.197
test_oobm_disable_feature_invalid | Success | 0.120
test_oobm_configure_invalid_driver | Success | 0.098
test_oobm_configure_default_driver | Success | 0.095
test_oobm_background_powerstate_sync | Success | 19.726
test_nic_secondaryip_add_remove | Success | 213.555
test_deployvm_userdispersing | Success | 20.571
test_deployvm_userdata_post | Success | 10.367
test_deployvm_userdata | Success | 55.722
test_deployvm_userconcentrated | Success | 30.639
test_deployvm_firstfit | Success | 50.595
test_deploy_vm_multiple | Success | 238.529
test_deploy_vm | Success | 0.031
test_delete_account | Success | 278.933
test_default_role_deletion | Success | 7.091
test_dedicatePublicIpRange | Success | 0.408
test_create_pvlan_network | Success | 5.231
test_createRegion | Success | 0.040
test_createPortablePublicIPRange | Success | 15.196
test_createPortablePublicIPAcquire | Success | 15.448
test_assign_and_removal_lb | Success | 133.736
test_advZoneVirtualRouter | Success | 0.024
test_UpdateStorageOverProvisioningFactor | Success | 0.147
test_UpdateConfigParamWithScope | Success | 0.152
test_DeployVmAntiAffinityGroup_in_project | Success | 121.453
test_DeployVmAntiAffinityGroup | Success | 65.938
test_CreateTemplateWithDuplicateName | Success | 60.574
test_10_destroy_cpvm | Success | 161.589
test_10_attachAndDetach_iso | Success | 71.543
test_09_reboot_router | Success | 35.316
test_09_expunge_vm | Success | 185.236
test_09_destroy_ssvm | Success | 163.253
test_09_delete_detached_volume | Success | 15.533
test_08_start_router | Success | 30.304
test_08_resize_volume | Success | 15.566
test_08_reboot_cpvm | Success | 101.368
test_08_migrate_vm | Success | 35.892
test_08_list_system_templates | Success | 0.031
test_07_stop_router | Success | 10.183
test_07_restore_vm | Success | 0.124
test_07_resize_fail | Success | 20.488
test_07_reboot_ssvm | Success | 103.550
test_07_list_public_templates | Success | 0.039
test_07_list_default_iso | Success | 0.064
test_06_stop_cpvm | Success | 131.548
test_06_router_advanced | Success | 0.058
test_06_download_detached_volume | Success | 15.366
test_06_destroy_vm | Success | 125.798
test_05_template_permissions | Success | 0.059
test_05_stop_ssvm | Success | 133.818
test_05_rvpc_multi_tiers | Success | 384.887
test_05_router_basic | Success | 0.042
test_05_iso_permissions | Success | 0.065
test_05_detach_volume | Success | 100.295
test_04_rvpc_network_garbage_collector_nics | Success | 790.154
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 239.552
test_04_restart_network_wo_cleanup | Success | 5.852
test_04_extract_template | Success | 5.293
test_04_extract_Iso | Success | 5.196
test_04_delete_attached_volume | Success | 10.200
test_04_create_fat_type_disk_offering | Success | 0.073
test_04_cpvm_internals | Success | 1.029
test_04_change_offering_small | Success | 204.977
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 188.044
test_03_ssvm_internals | Success | 3.422
test_03_restart_network_cleanup | Success | 60.552
test_03_reboot_vm | Success | 125.879
test_03_list_snapshots | Success | 0.058
test_03_download_attached_volume | Success | 15.323
test_03_delete_template | Success | 5.157
test_03_delete_service_offering | Success | 0.051
test_03_delete_iso | Success | 95.116
test_03_delete_disk_offering | Success | 0.042
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 420.456
test_03_RVR_Network_check_router_state | Success | 251.760
test_02_sys_template_ready | Success | 0.132
test_02_start_vm | Success | 10.183
test_02_router_internal_adv | Success | 0.931
test_02_port_fwd_on_non_src_nat | Success | 55.661
test_02_list_templates | Success | 0.040
test_02_list_cpvm_vm | Success | 0.147
test_02_isolate_network_FW_PF_default_routes_egress_false | Success | 196.707
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 510.392
test_02_edit_template | Success | 90.182
test_02_edit_service_offering | Success | 0.140
test_02_edit_iso | Success | 0.082
test_02_edit_disk_offering | Success | 0.053
test_02_deploy_vm_root_resize | Success | 6.896
test_02_create_sparse_type_disk_offering | Success | 0.070
test_02_create_lb_rule_non_nat | Success | 187.460
test_02_attach_volume | Success | 43.777
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Success | 270.521
test_01_updatevolumedetail | Success | 0.092
test_01_sys_vm_start | Success | 0.184
test_01_stop_vm | Success | 40.331
test_01_snapshot_root_disk | Success | 76.449
test_01_router_internal_basic | Success | 0.489
test_01_reset_vm_on_reboot | Success | 146.099
test_01_primary_storage_nfs | Success | 35.728
test_01_port_fwd_on_src_nat | Success | 111.807
test_01_nic | Success | 641.570
test_01_list_volumes | Success | 0.033
test_01_list_sec_storage_vm | Success | 0.136
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 421.457
test_01_deploy_vm_root_resize | Success | 7.086
test_01_create_volume | Success | 711.386
test_01_create_template | Success | 20.299
test_01_create_service_offering | Success | 0.122
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 997.981
test_01_create_lb_rule_src_nat | Success | 217.865
test_01_create_iso | Success | 66.961
test_01_create_disk_offering | Success | 0.123
test_01_VPC_nics_after_destroy | Success | 505.703
test_00_deploy_vm_root_resize | Success | 203.364
login_test_saml_user | Success | 24.534
test_vm_nic_adapter_vmxnet3 | Skipped | 0.001
test_static_role_account_acls | Skipped | 0.022
test_deploy_vgpu_enabled_vm | Skipped | 0.005
test_06_copy_template | Skipped | 0.000
test_06_copy_iso | Skipped | 0.000
test_03_delete_vm_snapshots | Skipped | 0.000
test_02_revert_vm_snapshots | Skipped | 0.000
test_01_test_vm_volume_snapshot | Skipped | 0.001
test_01_scale_vm | Skipped | 0.001
test_01_primary_storage_iscsi | Skipped | 0.037
test_01_create_vm_snapshots | Skipped | 0.000
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd 4.8 is still supported. However, support is for bug fixes, and this change is not a bug fix. 4.9 is an LTS branch which can take changes such as these. So I am cool with it being 4.9+ -- especially if it would require extra effort to accommodate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1696
Thanks @ustcweizhou
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@serg38 @rhtyd I am going to rollback this merge as it appears that the patch does not fix the issue. I would also like to explore @serg38's point that we shouldn't need to make code changes to support a new OS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd @jburwell @karuturi I confirm the same issue with this PR as with 'CLOUDSTACK-5922:Incorrect handling RHEL guests for 5.5 to 5.9
When Os type is specified as Ubuntu 16.04
and VM is started on VmWare it actually creates VM with OS type 'Other (64-bit)'
The fix was to put a respective entry into vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java
https://github.com/apache/cloudstack/commit/05c6b455ae89480d84ba5dfa4dc79d3336ebd458
Can we roll back this PR and make it right? An alternative path wold be to figure out why adding entries into tables is not good enough and why changes in the code is still required.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1696
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1696
I've manually kicked a trillian env (tid-84) to get an env against xenserver 6.5sp1, as soon as it comes up I'll perform the test to launch a Ubuntu 16.04 VM using templates from http://dl.openvm.eu/cloudstack/ubuntu/vanilla/16.04/x86_64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1696
The failures from the above result are not related to the change but with the env/tests, most of which have been addressed in #1692
With the enough test results, manual tests and lgtms, I'll proceed with the merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1696
Thanks @ustcweizhou I'll fix as suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1696
With a manually deployed Trillian environment based on XenServer 6.5sp1, I was able to register Ubuntu 16.04 and launch a VM. Screenshots attached:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@abhinandanprateek @murali-reddy please review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd @jburwell Actually ESX 6 mapping are here schema-461to470.sql
INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` values (25,UUID(),'VMware','6.0',128,0,13,32,1,1);
INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '6.0', guest_os_name, guest_os_id, utc_timestamp(), 0 FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='5.5' AND (guest_os_id NOT IN (1,2,3,4,62,63,64,65,156,157,221,222) AND guest_os_id NOT BETWEEN 121 AND 130);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1696
LGTM on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@jburwell As per our maintenance policy we only maintain n, n-1 branches i.e. master (upcoming 4.10) and 4.9. At no point we had ever maintained three branches, it's too much overhead. So, which is why I've avoided bug fixes to 4.8 branch. If necessary, I can port the fix to 4.8 branch but that would also require some additions to db upgrade paths (as 4.8.2.0 has blank upgrade paths) across 4.8, 4.9, master branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@ustcweizhou Hi, I think I used your changes here. VMware is sane to interpret Ubuntu guest vms as either ubuntuGuest or ubuntu64Guest (identifier used), while to XS and KVM full names are passed while may or may not exist. XenServer 6.5 and KVM/LXC may not understand/interpret Ubuntu 16.04 correctly so, the workaround here is to tell the hypervisor(s) to treat VMs of this guest os id/type to be a Ubuntu 14.04.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd I think it is not an issue in KVM/LXC.
the guest pv is checked by this line in plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
if (guestOSName.startsWith("Ubuntu") || guestOSName.startsWith("Fedora 13") || guestOSName.startsWith("Fedora 12")
by the way, this file is not used any more so it can be removed: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/KVMGuestOsMapper.java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@jburwell @rhtyd Sorry for a flood of messages. I checked and we do have mapping for all OS for Vmware 6 in ACS. It was introduced in 4.7 so that means this PR needs to have those 2 lines added (or a new PR created for this)
INSERT IGNORE INTO cloud.guest_os_hypervisor (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '6.0', 'ubuntuGuest', 255, utc_timestamp(), 0);
INSERT IGNORE INTO cloud.guest_os_hypervisor (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '6.0', 'ubuntu64Guest', 256, utc_timestamp(), 0);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@jburwell @rhtyd I apologies. The issue in our environment was due to using ESX v6. Once I added new mapping for it Vmware properly assigned Os type. It would be nice to officially certify ESX6 for ACS. It has been a supported platform for one of the commercial distribution for some time already.
INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '6.0', 'ubuntuGuest', 255, utc_timestamp(), 0);
INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '6.0', 'ubuntu64Guest', 256, utc_timestamp(), 0);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd I might be mistaken but you also need to add mapping into
cloudstack/vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper
In the past if not added on vmware it would create VM with 'Other-64 bit' OS type e.g.
CLOUDSTACK-5922:Incorrect handling RHEL guests for 5.5 to 5.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@ustcweizhou @abhinandanprateek @murali-reddy @jburwell review? Manual tests confirm that it works on XenServer 6.5.
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1696
Hi @rhtyd there are some typo in my comment, it should be "Ubuntu 16.04" not "Ubuntu 14.04" in some lines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@jburwell rollback is not necessary. We've no guest os mappings for VMware 6.0, those need to be added. If needed, I can send a new PR. /cc @serg38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@serg38 good catch regarding vSphere 6. As I noted earlier, I will be rolling back this merge, and we will address it on re-submission.
Once we resolve the VMware 5.5, XenServer 6.5, and KVM smoke test issues in #1692, we plan to execute the vSphere6 certification tests for 4.9.1.0 and 4.10.0.0. In anticipation of this testing, vSphere 6 support has already been added to Trillian and blueorangutan. It hasn't been added to the default matrix in order to avoid any additional variables stabilizing the smoke test suite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd do you think we should include this update in 4.8.2.0 as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1696
tested on KVM, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1696
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd @jburwell Please don't forget to close loop on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---