You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/12/30 18:45:54 UTC

[GitHub] [maven-changes-plugin] Nyamiou opened a new pull request #1: Fix the issue MCHANGES-398 that was caused by the change MPIR-323

Nyamiou opened a new pull request #1: Fix the issue MCHANGES-398 that was caused by the change MPIR-323
URL: https://github.com/apache/maven-changes-plugin/pull/1
 
 
   A fix for the issue MCHANGES-398 which was caused by the change MPIR-323 to Maven Project Info Reports Plugin. Now the default page for the team list is "team.html" and no more "team-list.html".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-changes-plugin] michael-o commented on a change in pull request #1: Fix the issue MCHANGES-398 that was caused by the change MPIR-323

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #1: Fix the issue MCHANGES-398 that was caused by the change MPIR-323
URL: https://github.com/apache/maven-changes-plugin/pull/1#discussion_r362074040
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/changes/ChangesMojo.java
 ##########
 @@ -191,7 +191,7 @@
      *
      * @since 2.4
      */
-    @Parameter( defaultValue = "team-list.html" )
+    @Parameter( defaultValue = "team.html" )
     private String teamlist;
 
 Review comment:
   You shouls also rename the field name to make it consistent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-changes-plugin] asfgit closed pull request #1: Fix the issue MCHANGES-398 that was caused by the change MPIR-323

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1: Fix the issue MCHANGES-398 that was caused by the change MPIR-323
URL: https://github.com/apache/maven-changes-plugin/pull/1
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-changes-plugin] Nyamiou commented on a change in pull request #1: Fix the issue MCHANGES-398 that was caused by the change MPIR-323

Posted by GitBox <gi...@apache.org>.
Nyamiou commented on a change in pull request #1: Fix the issue MCHANGES-398 that was caused by the change MPIR-323
URL: https://github.com/apache/maven-changes-plugin/pull/1#discussion_r362209712
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/changes/ChangesMojo.java
 ##########
 @@ -191,7 +191,7 @@
      *
      * @since 2.4
      */
-    @Parameter( defaultValue = "team-list.html" )
+    @Parameter( defaultValue = "team.html" )
     private String teamlist;
 
 Review comment:
   Done, the parameter is now "team".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services