You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/16 10:18:24 UTC
[GitHub] [superset] mona-mk opened a new issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
mona-mk opened a new issue #15738:
URL: https://github.com/apache/superset/issues/15738
Legend is shown as NaN in deck.gl scatter plot when TEXT or STRING column data type is selected as point color.
<img width="589" alt="Screenshot 2021-07-16 at 11 12 50" src="https://user-images.githubusercontent.com/59080347/125915292-ca1664db-c776-4683-9097-5a3fe811435b.png">
1. Geneate a deck.gl plot
2. Under point color, pick a TEXT or STRING column
3. See NaN as legend
Environment:
- superset version: `1.2.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Deninc commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
Deninc commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-917941174
> @mona-mk @fcomuniz @colorzhang this is now fixed on master, feel free to try it out at your convenience
How do I check when this is merged into the official release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] fcomuniz commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
fcomuniz commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-882598166
Same issue here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mona-mk commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
mona-mk commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-935563910
Thanks a lot Ville for your update. I would appreciate if we could get it released soon. Looking forward to it 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mona-mk commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
mona-mk commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-901649540
Thanks Ville. Further (easier) description on how to reproduce:
1. Open `deck.gl Demo` dashboard
2. On `Scatterplot` demo, click on three vertical dots on the right corner and select `View chart in Explore`
3. Under point color, select a TEXT dimension (in screen shot I randomly picked `STREET`)
4. You will see NaN in legend
Of course this is a dummy example, but hopefully will clarify the problem. Please see the requested screen shots enclosed. Expected result in this case is seeing the street names in legend, i.e. based on Data screen shot:
- Fulton Street
- Mason Street
- Hyde Street
- ....
Also, changing the formatting to `Original value` doesn't help.
<img width="1915" alt="Screenshot 2021-08-19 at 9 31 45" src="https://user-images.githubusercontent.com/59080347/130019353-111c2559-5912-4332-ac2e-8a97a54116c9.png">
<img width="1284" alt="Screenshot 2021-08-19 at 9 33 09" src="https://user-images.githubusercontent.com/59080347/130019513-2c53ac1d-1754-404d-ab08-f226b454413b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-901842493
@mona-mk here's the fix PR: https://github.com/apache-superset/superset-ui-plugins-deckgl/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mona-mk commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
mona-mk commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-934370814
@villebro today I pulled `1.3.0` and `1.3.1` images, and I still have this bug. Isn't it already included in one of the official releases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] fcomuniz commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
fcomuniz commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-882598166
Same issue here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-899259926
Would it be possible to add some more context? (redacted of course)
- Screenshots of the Explore view, especially the critical parts of the control panel
- Screenshots of the data panel (both results and samples)
- Expected result in the legend based on the data based on what's visible in the screenshots
Point being, by making the problem as easy to reproduce as possible, the community can focus developer time on working on the fix as opposed to reproducing the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-934402260
@mona-mk unfortunately due to our current multirepo setup, it's very difficult to cherrypick viz plugin fixes into official Apache releases after a release branch has been cut. But we should be cutting the 1.4 branch very soon, so if you can wait just a little while longer it will be included in an official release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] fcomuniz commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
fcomuniz commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-882598166
Same issue here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-901728603
Hi @mona-mk , I was able to reproduce and was able to come up with a quick fix (I also fixed the broken tooltip at the same time):
I'll clean up the PR and open it in a sec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro closed issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
villebro closed issue #15738:
URL: https://github.com/apache/superset/issues/15738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MichaelTiemannOSC commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
MichaelTiemannOSC commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-982468383
Just hit this myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mona-mk commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
mona-mk commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-902470160
Thanks you very much Ville! Just pulled the `latest-dev` image and tested. Confirm it works as it should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-902068962
@mona-mk @fcomuniz @colorzhang this is now fixed on master, feel free to try it out at your convenience
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] colorzhang commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
colorzhang commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-893463263
tried today. same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] fcomuniz commented on issue #15738: deck.gl Scatterplot NaN legend for TEXT/STRING column
Posted by GitBox <gi...@apache.org>.
fcomuniz commented on issue #15738:
URL: https://github.com/apache/superset/issues/15738#issuecomment-902091741
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org