You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/02 04:31:21 UTC

[GitHub] [calcite] jacques-n opened a new pull request #2624: [CALCITE-4914] Introduce HandlerBasedRelMetdataQuery as an extension point

jacques-n opened a new pull request #2624:
URL: https://github.com/apache/calcite/pull/2624


   This is a precursor to implementing CALCITE-4879. It tries to better encapsulate
   separate the consumption side of RelMetaDataQuery from the production side. This
   includes:
   - Mark the public fields in RelMetadataQueryBase as INTERNAL fields
   - Deprecate the static initialHandler method and replace it with a class level createInitialHandler
   - Deprecate the public constructor of RelMetadataQuery to avoid direct extension
   - Introduce a new HandlerBasedRelMetdataQuery that will house the handler specific
     concepts in a future release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] jacques-n edited a comment on pull request #2624: [CALCITE-4914] Introduce HandlerBasedRelMetdataQuery as an extension point

Posted by GitBox <gi...@apache.org>.
jacques-n edited a comment on pull request #2624:
URL: https://github.com/apache/calcite/pull/2624#issuecomment-997120386


   Due to discussions on jira, abandoning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] jacques-n commented on pull request #2624: [CALCITE-4914] Introduce HandlerBasedRelMetdataQuery as an extension point

Posted by GitBox <gi...@apache.org>.
jacques-n commented on pull request #2624:
URL: https://github.com/apache/calcite/pull/2624#issuecomment-984289441


   Adding @julianhyde as a reviewer as he expressed some concerns around this work on Jira.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] jacques-n commented on pull request #2624: [CALCITE-4914] Introduce HandlerBasedRelMetdataQuery as an extension point

Posted by GitBox <gi...@apache.org>.
jacques-n commented on pull request #2624:
URL: https://github.com/apache/calcite/pull/2624#issuecomment-997120386


   Due to discussionsing on jira, abandoning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] jacques-n closed pull request #2624: [CALCITE-4914] Introduce HandlerBasedRelMetdataQuery as an extension point

Posted by GitBox <gi...@apache.org>.
jacques-n closed pull request #2624:
URL: https://github.com/apache/calcite/pull/2624


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org