You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Weiyan Wang <we...@fb.com> on 2011/11/09 09:58:03 UTC

Re: Review Request: HIVE-2247 Changed the Thrift API causing compatibility issues.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/
-----------------------------------------------------------

(Updated 2011-11-09 08:58:03.327969)


Review request for hive, Siying Dong and Kevin Wilfong.


Summary
-------

keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch


This addresses bug HIVE-2247.
    https://issues.apache.org/jira/browse/HIVE-2247


Diffs
-----

  trunk/metastore/if/hive_metastore.thrift 1199598 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598 
  trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598 

Diff: https://reviews.apache.org/r/2783/diff


Testing
-------


Thanks,

Weiyan

Re: Review Request: [HIVE-2562] HIVE-2247 Changed the Thrift API causing compatibility issues.

Posted by Weiyan Wang <we...@fb.com>.

> On 2011-11-09 17:01:46, Ning Zhang wrote:
> > trunk/metastore/if/hive_metastore.thrift, line 373
> > <https://reviews.apache.org/r/2783/diff/2/?file=56941#file56941line373>
> >
> >     can this function just called rename_partition().
> 
> Kevin Wilfong wrote:
>     I agree with Ning's comment about the function name, everything else looks good to me.

I am still running all unit tests.


- Weiyan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/#review3131
-----------------------------------------------------------


On 2011-11-09 21:38:50, Weiyan Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2783/
> -----------------------------------------------------------
> 
> (Updated 2011-11-09 21:38:50)
> 
> 
> Review request for hive, Siying Dong and Kevin Wilfong.
> 
> 
> Summary
> -------
> 
> keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null
> 
> Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch
> 
> 
> This addresses bug HIVE-2562.
>     https://issues.apache.org/jira/browse/HIVE-2562
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/if/hive_metastore.thrift 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943 
>   trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943 
>   trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943 
>   trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943 
> 
> Diff: https://reviews.apache.org/r/2783/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Weiyan
> 
>

Re: Review Request: [HIVE-2562] HIVE-2247 Changed the Thrift API causing compatibility issues.

Posted by Kevin Wilfong <ke...@fb.com>.

> On 2011-11-09 17:01:46, Ning Zhang wrote:
> > trunk/metastore/if/hive_metastore.thrift, line 373
> > <https://reviews.apache.org/r/2783/diff/2/?file=56941#file56941line373>
> >
> >     can this function just called rename_partition().

I agree with Ning's comment about the function name, everything else looks good to me.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/#review3131
-----------------------------------------------------------


On 2011-11-09 09:04:42, Weiyan Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2783/
> -----------------------------------------------------------
> 
> (Updated 2011-11-09 09:04:42)
> 
> 
> Review request for hive, Siying Dong and Kevin Wilfong.
> 
> 
> Summary
> -------
> 
> keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null
> 
> Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch
> 
> 
> This addresses bug HIVE-2562.
>     https://issues.apache.org/jira/browse/HIVE-2562
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/if/hive_metastore.thrift 1199598 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598 
>   trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598 
>   trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598 
>   trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598 
> 
> Diff: https://reviews.apache.org/r/2783/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Weiyan
> 
>

Re: Review Request: [HIVE-2562] HIVE-2247 Changed the Thrift API causing compatibility issues.

Posted by Ning Zhang <nz...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/#review3131
-----------------------------------------------------------



trunk/metastore/if/hive_metastore.thrift
<https://reviews.apache.org/r/2783/#comment6944>

    can this function just called rename_partition().


- Ning


On 2011-11-09 09:04:42, Weiyan Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2783/
> -----------------------------------------------------------
> 
> (Updated 2011-11-09 09:04:42)
> 
> 
> Review request for hive, Siying Dong and Kevin Wilfong.
> 
> 
> Summary
> -------
> 
> keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null
> 
> Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch
> 
> 
> This addresses bug HIVE-2562.
>     https://issues.apache.org/jira/browse/HIVE-2562
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/if/hive_metastore.thrift 1199598 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598 
>   trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598 
>   trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598 
>   trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598 
> 
> Diff: https://reviews.apache.org/r/2783/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Weiyan
> 
>

Re: Review Request: [HIVE-2562] HIVE-2247 Changed the Thrift API causing compatibility issues.

Posted by Ning Zhang <nz...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/#review3141
-----------------------------------------------------------



trunk/metastore/if/hive_metastore.thrift
<https://reviews.apache.org/r/2783/#comment6951>

    can you keep the comments for this method (after reverting the changes to the comments as well). 



trunk/metastore/if/hive_metastore.thrift
<https://reviews.apache.org/r/2783/#comment6952>

    the comment here is not clear. are you changing the name of new_part with the name specified by part_vals or you want to change the partition identified by part_vals with the name found in new_part? 


- Ning


On 2011-11-09 21:38:50, Weiyan Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2783/
> -----------------------------------------------------------
> 
> (Updated 2011-11-09 21:38:50)
> 
> 
> Review request for hive, Siying Dong and Kevin Wilfong.
> 
> 
> Summary
> -------
> 
> keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null
> 
> Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch
> 
> 
> This addresses bug HIVE-2562.
>     https://issues.apache.org/jira/browse/HIVE-2562
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/if/hive_metastore.thrift 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943 
>   trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943 
>   trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943 
>   trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943 
> 
> Diff: https://reviews.apache.org/r/2783/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Weiyan
> 
>

Re: Review Request: [HIVE-2562] HIVE-2247 Changed the Thrift API causing compatibility issues.

Posted by Ning Zhang <nz...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/#review3150
-----------------------------------------------------------

Ship it!


- Ning


On 2011-11-10 05:46:57, Weiyan Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2783/
> -----------------------------------------------------------
> 
> (Updated 2011-11-10 05:46:57)
> 
> 
> Review request for hive, Siying Dong and Kevin Wilfong.
> 
> 
> Summary
> -------
> 
> keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null
> 
> Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch
> 
> 
> This addresses bug HIVE-2562.
>     https://issues.apache.org/jira/browse/HIVE-2562
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/if/hive_metastore.thrift 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943 
>   trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943 
>   trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943 
>   trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943 
> 
> Diff: https://reviews.apache.org/r/2783/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Weiyan
> 
>

Re: Review Request: [HIVE-2562] HIVE-2247 Changed the Thrift API causing compatibility issues.

Posted by Weiyan Wang <we...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/
-----------------------------------------------------------

(Updated 2011-11-10 05:46:57.500909)


Review request for hive, Siying Dong and Kevin Wilfong.


Summary
-------

keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch


This addresses bug HIVE-2562.
    https://issues.apache.org/jira/browse/HIVE-2562


Diffs (updated)
-----

  trunk/metastore/if/hive_metastore.thrift 1199943 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943 
  trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943 

Diff: https://reviews.apache.org/r/2783/diff


Testing
-------


Thanks,

Weiyan

Re: Review Request: [HIVE-2562] HIVE-2247 Changed the Thrift API causing compatibility issues.

Posted by Weiyan Wang <we...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/
-----------------------------------------------------------

(Updated 2011-11-09 21:38:50.463372)


Review request for hive, Siying Dong and Kevin Wilfong.


Changes
-------

Address Ning's comment


Summary
-------

keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch


This addresses bug HIVE-2562.
    https://issues.apache.org/jira/browse/HIVE-2562


Diffs (updated)
-----

  trunk/metastore/if/hive_metastore.thrift 1199943 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943 
  trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943 

Diff: https://reviews.apache.org/r/2783/diff


Testing
-------


Thanks,

Weiyan

Re: Review Request: [HIVE-2562] HIVE-2247 Changed the Thrift API causing compatibility issues.

Posted by Weiyan Wang <we...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/
-----------------------------------------------------------

(Updated 2011-11-09 09:04:42.416457)


Review request for hive, Siying Dong and Kevin Wilfong.


Changes
-------

I thought this patch is going to fix the bug in HIVE-2247, so I should put HIVE-2247 in the bugs field...It seems it is not like what I think.


Summary (updated)
-------

keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch


This addresses bug HIVE-2562.
    https://issues.apache.org/jira/browse/HIVE-2562


Diffs
-----

  trunk/metastore/if/hive_metastore.thrift 1199598 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598 
  trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598 

Diff: https://reviews.apache.org/r/2783/diff


Testing
-------


Thanks,

Weiyan