[GitHub] franz1981 commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

[GitBox <gi...@apache.org>]

franz1981 commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer
URL: https://github.com/apache/activemq-artemis/pull/2522#issuecomment-457819129
 
 
   @michaelandrepearce 
   
   > Have you got any stats to share on this, especially on running on standardish spec server? Im assuming that its quite a good improvement based on it removes copies :) , but be good for the record like....
   
   Not yet: I can just say that on my box `fsync` is such heavy-weight that is difficult to measure the gain of this improvement. 
   If I would use a `tmpfs` folder for the journal instead it would just show that zeroing (and copying) is just the major cost and the speedup is so dramatical that is just unrealistic.
   
   @clebertsuconic @michaelandrepearce I will try to get a proper benchmark box to find out this, but nonetheless I'm expecting *at least* a better ability from NIO/MAPPED to maintain the buffer timeout: the next big improvement would be to run `fsync` on a separate "coalescing" thread (similarly to what libaio does on the blocked poll).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services