[GitHub] [iceberg] openinx commented on a change in pull request #2854: Spark catalog: fixed hardcoded purge option in drop table action

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2854:
URL: https://github.com/apache/iceberg/pull/2854#discussion_r676260116



##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -81,13 +81,17 @@
 public class SparkCatalog extends BaseCatalog {
   private static final Set<String> DEFAULT_NS_KEYS = ImmutableSet.of(TableCatalog.PROP_OWNER);
 
+  public static final String PURGE_DATA_AND_METADATA = "purge-data-and-metadata";

Review comment:
       If we plan to introduce such a configure key,  it should be applied to all the catalogs (such as hive,hadoop and other custom catalogs)  , instead of a specific property for spark catalog ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org