[jira] [Comment Edited] (HBASE-17118) StoreScanner leaked in KeyValueHeap

["binlijin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672406#comment-15672406 ] 

binlijin edited comment on HBASE-17118 at 11/17/16 7:27 AM:
------------------------------------------------------------

We find the problem so later, and could not find the HFile which cause the IllegalArgumentException, and have no clue about the IllegalArgumentException yet.


was (Author: aoxiang):
We find the problem so later, and could find the HFile which cause the IllegalArgumentException, and have no clue about the IllegalArgumentException yet.

> StoreScanner leaked in KeyValueHeap
> -----------------------------------
>
>                 Key: HBASE-17118
>                 URL: https://issues.apache.org/jira/browse/HBASE-17118
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: binlijin
>            Assignee: binlijin
>         Attachments: HBASE-17118-master_v1.patch, HBASE-17118-master_v2.patch, HBASE-17118-master_v3.patch, StoreScanner.png, StoreScannerLeakHeap.png
>
>
> KeyValueHeap#generalizedSeek
>       KeyValueScanner scanner = current;
>       while (scanner != null) {
>         Cell topKey = scanner.peek();
>         ......
>         boolean seekResult;
>         if (isLazy && heap.size() > 0) {
>           // If there is only one scanner left, we don't do lazy seek.
>           seekResult = scanner.requestSeek(seekKey, forward, useBloom);
>         } else {
>           seekResult = NonLazyKeyValueScanner.doRealSeek(scanner, seekKey,
>               forward);
>         }
>         ......
>         scanner = heap.poll();
>       }
> (1) scanner = heap.poll();  Retrieves and removes the head of this queue
> (2) scanner.requestSeek(seekKey, forward, useBloom); or NonLazyKeyValueScanner.doRealSeek(scanner, seekKey, forward);
> throw exception, and scanner will have no chance to close, so will cause the scanner leak.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)