[GitHub] [jackrabbit-filevault] reschke commented on a diff in pull request #295: JCRVLT-707: update to Jackrabbit 2.20.10 and Oak 1.52.0

["reschke (via GitHub)" <gi...@apache.org>]

reschke commented on code in PR #295:
URL: https://github.com/apache/jackrabbit-filevault/pull/295#discussion_r1195004612


##########
parent/pom.xml:
##########
@@ -373,7 +374,7 @@ Bundle-Category: jackrabbit
             <dependency>
                 <groupId>org.apache.jackrabbit</groupId>
                 <artifactId>oak-jackrabbit-api</artifactId>
-                <version>${oak.version}</version>
+                <version>${oak.version.compile}</version>

Review Comment:
   > I know that you disagree here, but again, that is the job of the distribution to ship current runtime dependencies.
   
   Yes. But. Shouldn't we encourage users of FileVault to stop using unmaintained versions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org