You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/06/24 07:53:01 UTC
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Indhumathi27 commented on a change in pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#discussion_r657711504
##########
File path: integration/spark/src/main/common2.3and2.4/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
##########
@@ -25,7 +25,7 @@ import org.apache.spark.sql.catalyst.parser.SqlBaseParser._
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.execution.{SparkSqlAstBuilder, SparkSqlParser}
import org.apache.spark.sql.internal.{SQLConf, VariableSubstitution}
-import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.needToConvertToLowerCase
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.{convertPropertiesToLowercase, needToConvertToLowerCase}
Review comment:
remove unused import
##########
File path: integration/spark/src/main/spark3.1/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
##########
@@ -25,6 +25,8 @@ import org.apache.spark.sql.catalyst.parser.SqlBaseParser._
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.execution.{SparkSqlAstBuilder, SparkSqlParser}
import org.apache.spark.sql.internal.{SQLConf, VariableSubstitution}
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.convertPropertiesToLowercase
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.needToConvertToLowerCase
Review comment:
remove unsued import
##########
File path: integration/spark/src/main/spark3.1/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
##########
@@ -25,6 +25,8 @@ import org.apache.spark.sql.catalyst.parser.SqlBaseParser._
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.execution.{SparkSqlAstBuilder, SparkSqlParser}
import org.apache.spark.sql.internal.{SQLConf, VariableSubstitution}
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.convertPropertiesToLowercase
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.needToConvertToLowerCase
Review comment:
remove unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org