[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37616: [SPARK-40178][PYTHON][SQL] Fix partitioning hint parameters in PySpark

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #37616:
URL: https://github.com/apache/spark/pull/37616#discussion_r1022305164


##########
python/pyspark/sql/dataframe.py:
##########
@@ -968,7 +968,7 @@ def hint(
         if not isinstance(name, str):
             raise TypeError("name should be provided as str, got {0}".format(type(name)))
 
-        allowed_types = (str, list, float, int)
+        allowed_types = (str, Column, int)

Review Comment:
   Maybe we can add `Column` into this allowed list, and leave things as are because other custom types would be broken without this. BTW, does Scala support such hint too? e.g, `df.hint("REPARTITION", "a")`. This method calls Scala side directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org